Reduce log volume forwarded through Thespian framework #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpifke-elastic
added
the
cleanup
dpifke-elastic
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of Thespian messages containing forwarded logs contributing to #1448.
I don't understand
actorSystemCapabilityCheck()behavior, asDEBUGlogs should not be forwarded. I've raised this with Thespian maintainer, but have not received additional explanations so far. As we cannot get lower thanDEBUGI'm simply removing those logs.The
WARNINGlog about SSL verification being off being forwarded through Thespian is expected.See thespianpy/Thespian#82 (comment) for additional context, and potential follow-up in the future.