Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v32.0.4 #96459

Merged
merged 13 commits into from
Apr 14, 2021
Merged

Upgrade EUI to v32.0.4 #96459

merged 13 commits into from
Apr 14, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 7, 2021 •
edited
Loading

Summary

v31.10.0 ⏩ v32.0.4

EuiPanel breaking changes were accounted for in a previous PR

  • Refactored internal structure and class names in EuiCard
  • Refactored internal structure of EuiButtonGroup
  • Tightened prop types of EuiAvatar
  • Updated styles for EuiPagination

32.0.4

Bug fixes

  • Removed the restriction on selectable EuiCard with layout="horizontal" (#4692)

32.0.3

Bug fixes

  • Exported EuiAvatarProps (#4690)
  • Fixed type overrides in EuiCard (#4690)

32.0.2

Bug fixes

  • Fixed htmlIdGenerator import path in button_group_button.tsx (#4682)
  • Fixed EuiColorStops popover failing to close (#4687)

32.0.1

Bug fixes

  • Fixed block style of EuiPanel when rendered as a <button> (#4681)

32.0.0

  • Added stepNumber prop and stepped as stopType option to EuiColorStops (#4613)
  • Expanded display prop of EuiCard to inherit color values from EuiPanel (#4649)
  • Added element prop to EuiPanel for forcing to div or button (#4649)
  • Increased padding on EuiCheckableCard with refactor to use EuiSplitPanel (#4649)
  • Added valueInputProps prop to EuiColorStops (#4669)
  • Added position, usePortal, top, right, bottom, and left props to EuiBottomBar (#4662)
  • Added bottomBar and bottomBarProps to EuiPageTemplate when template = 'default' (#4662)
  • Added role="main" to EuiPageContent by default (#4662)
  • Added bottomBorder prop to EuiPageHeader (#4662)

Bug fixes

  • Fixed id attribute to be unique across EuiButtonGroupButton elements (#4657)
  • Fixed responsive sizing of EuiModal (#4670)
  • Fixed disabled interactions of EuiHeaderSectionItemButton (#4670)
  • Hid of text on small screens for compressed EuiPagination(#4661)

Breaking changes

  • Removed betaBadgeLabel, betaBadgeTooltipContent, and betaBadgeTitle props from EuiPanel (#4649)
  • Changed EuiBottomBar positioning styles from being applied at the CSS layer to the style property (#4662)

31.12.0

  • Added indexRuntime glyph in EuiIcon (#4650)
  • Added iconType, iconColor, and iconSize props to EuiAvatar (#4620)
  • Added 'plain' and null as color options of EuiAvatar (#4620)

31.11.0

  • Added EuiNotificationEvent component (#4513)
  • Added euiAnimation() method on the EuiHeaderSectionItemButton ref (#4513)
  • Made description prop of EuiCard optional (#4546)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.13.0 labels Apr 7, 2021
@thompsongl
Copy link
Contributor Author

thompsongl commented Apr 7, 2021 •
edited
Loading

Error: EuiCard: layout = horizontal' cannot be used in conjunction with 'image', 'footer', 'textAlign', or 'selectable'.

From select_rule_type
@cchaos was this one of the necessary EuiCard changes that you were tracking?

Edit: Changing the rule in EUI to allow the configuration in question

@thompsongl thompsongl changed the title Upgrade EUI to v32.0.3 Upgrade EUI to v32.0.4 Apr 7, 2021
@dej611 dej611 mentioned this pull request Apr 8, 2021
Merged
3 tasks
thompsongl
thompsongl commented Apr 8, 2021
View reviewed changes
test/functional/apps/discover/_data_grid_doc_table.ts
// with the default range the number of hits is ~14000
const rows = await dataGrid.getDocTableRows();
expect(rows.length).to.be(12);
expect(rows.length).to.be(11);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased size of EuiPagination slightly reduces the visible area, causing 1 fewer virtualized item.

@thompsongl thompsongl marked this pull request as ready for review April 8, 2021 19:29
@thompsongl thompsongl requested review from a team as code owners April 8, 2021 19:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

cnasikas
cnasikas approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security solution changes LTGM

sebelga
sebelga approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES UI changes LGTM 👍

shahzad31
shahzad31 approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM !!

smith
smith approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good

nchaulet
nchaulet approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 942.3KB 942.6KB +352.0B
security 713.4KB 713.6KB +196.0B
securitySolution 7.3MB 7.3MB +63.0B
spaces 287.1KB 287.2KB +100.0B
triggersActionsUi 1.5MB 1.5MB +1.6KB
total +2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 377.0KB 377.4KB +440.0B
data 788.2KB 788.7KB +584.0B
kbnUiSharedDeps-css 501.5KB 501.4KB -163.0B
kbnUiSharedDeps-elastic 3.3MB 3.3MB +16.3KB
kbnUiSharedDeps-js 6.7MB 6.7MB +44.0B
searchprofiler 40.2KB 40.4KB +224.0B
visTypeTimeseries 109.7KB 110.2KB +472.0B
total +17.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cqliu1
cqliu1 approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot changes for Canvas LGTM 👍

@thompsongl thompsongl merged commit d679035 into elastic:master Apr 14, 2021
@thompsongl thompsongl mentioned this pull request Apr 14, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Apr 14, 2021
@thompsongl
Upgrade EUI to v32.0.4 (elastic#96459)
65a4411 
* eui to 31.12.0

* type updates

* snapshot updates

* snapshot updates

* euiavatarprops

* eui to 32.0.3

* euicard updates

* update test
thompsongl added a commit that referenced this pull request Apr 14, 2021
@thompsongl
Upgrade EUI to v32.0.4 (#96459) (#97147)
9971605 
* eui to 31.12.0

* type updates

* snapshot updates

* snapshot updates

* euiavatarprops

* eui to 32.0.3

* euicard updates

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@mattkime mattkime mattkime approved these changes

@nchaulet nchaulet nchaulet approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@sebelga sebelga sebelga approved these changes

@legrego legrego legrego approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.