Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fstream dependency (1.0.11 → 1.0.12). #53932

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Update fstream dependency (1.0.11 → 1.0.12). #53932

merged 3 commits into from
Jan 14, 2020

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Jan 3, 2020 •
edited
Loading

Summary

Upgrades minimum version of fstream we rely on from 1.0.11 to 1.0.12:
Release notes - N/A, diff v1.0.11...v1.0.12

@azasypkin azasypkin added chore release_note:skip Skip the PR/issue when compiling release notes v7.6.0 7.5.2 and removed 7.5.2 labels Jan 3, 2020
azasypkin
azasypkin commented Jan 3, 2020
View reviewed changes
src/cli_plugin/install/download.test.js Outdated
@@ -37,7 +37,7 @@ describe('kibana cli', function() {
urls: [],
workingPath: testWorkingPath,
tempArchiveFile: tempArchiveFilePath,
timeout: 0,
timeout: 2000,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-operations I did patch version bump (from 2.2.1 to 2.2.4) for https-proxy-agent and should use https_proxy for secure URLs test started to fail with Jest timeout, so I had to switch to a finite timeout.

Does either current or previous behavior raise a red flag for you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azasypkin I did not spot any reason that would cause that to fail. The only place where that timeout is used is at https://github.com/elastic/kibana/blob/46e7af9c35a1945d1cd0e4cf93b4b37bfb30a176/src/cli_plugin/install/downloaders/http.js#L53 and is passed to @hapi/wreck

The only issue I found on https-proxy-agent mentioning a problem with jest timeouts was that one TooTallNate/proxy-agents#75 but it does not look related.

@azasypkin azasypkin force-pushed the issue-xxx-dep-update branch from 46e7af9 to 9d65706 Compare January 14, 2020 07:49
@azasypkin
Copy link
Member Author

Removed https-proxy-agent update from this PR as it's handled separately in #54478

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #17765 succeeded 46e7af9c35a1945d1cd0e4cf93b4b37bfb30a176
  • 💔 Build #17746 failed 3ba771928ea1a2d893b9a0279d5d4061265a6f1d
  • 💔 Build #17736 failed 3ba771928ea1a2d893b9a0279d5d4061265a6f1d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin requested a review from legrego January 14, 2020 09:19
@azasypkin azasypkin changed the title Update fstream and geckodriver dependencies. Update fstream dependency (1.0.11 → 1.0.12). Jan 14, 2020
@azasypkin azasypkin merged commit 6b6bc39 into elastic:master Jan 14, 2020
@azasypkin azasypkin deleted the issue-xxx-dep-update branch January 14, 2020 12:37
@azasypkin azasypkin mentioned this pull request Jan 14, 2020
Merged
azasypkin added a commit that referenced this pull request Jan 14, 2020
@azasypkin
Update fstream dependency (1.0.11 → 1.0.12). (#53932) (#54711)
2f87d85
@azasypkin
Copy link
Member Author

7.x/7.6.0: 2f87d85

jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@azasypkin @jkelastic
Update fstream dependency (1.0.11 → 1.0.12). (elastic#53932)
02678b7
jportner added a commit to jportner/kibana that referenced this pull request Apr 30, 2020
@jportner
Update fstream dependency (elastic#53932)
38807c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic left review comments

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azasypkin @kibanamachine @legrego @mistic