[Lens] use data plugin migrations for search sources in legacy visualizations

[drewdaemon]

Summary

This PR applies (not-yet-existent) search source migrations defined in the data plugin to the embedded search source objects in legacy visualizations.

How to Test

Saved Object Migrations

Search Sources in Legacy Visualizations

• Add the following dummy search source migration here

const searchSourceMigrations = {
    '8.1.0': (searchSource: SerializedSearchSourceFields) => ({ ...searchSource, migrated: true }),
  };

• Start and open Kibana
• Visit "Stack Management" -> "Saved objects"
• Import these saved objects
• this will add two objects to verify (plus the index pattern)
  • Dashboard with Visualization with Search Source
    • check that visState.data.searchSource === true in the visualization serialized in attributes.panelsJSON
  • Gauge with Search Source
    • check that JSON.parse(SO.attributes.kibanaSavedObjectMeta.searchSourceJSON).migrated === true

Filters in Lens

(make sure the functionality introduced in #120305 has not regressed)

• Add the following dummy filter migration here

export const getAllMigrations = (): MigrateFunctionsObject => {
  return {
    '8.1.0': (filters: Filter[]) => filters.map((filter) => ({ ...filter, migrated: true })),
  };
};

• Start and open Kibana
• Visit "Stack Management" -> "Saved objects"
• Import these saved objects
• this will add three objects to verify (plus the index pattern)
  • Dashboard with Embedded Lens Visualizations with Filters
  • standalone table with filters
  • standalone bar chart with filter
• Verify that each filter in the visualization states
  1. Has no indexRefName property. Instead, it should have an index property.
  2. Has a migrated: true property.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[drewdaemon]

@elasticmachine merge upstream

[drewdaemon]

@elasticmachine merge upstream

[drewdaemon]

@elasticmachine merge upstream

[flash1293]

@elasticmachine merge upstream

[flash1293]

Tested by adding example migrations to by value and by reference lens and visualization SOs as well as search source and filters - everything gets reflected as expected in all places, LGTM

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 3be8e9b
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
core	968	970	+2
visualizations	283	296	+13
total			+15

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
visualizations	11	12	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	449.7KB	449.7KB	+36.0B

Unknown metric groups

API count

id	before	after	diff
core	2353	2356	+3
visualizations	303	316	+13
total			+16

History

• 💚 Build #20296 succeeded b93bf87
• 💚 Build #20091 succeeded 31ec230
• 💚 Build #19547 succeeded 15cd67d
• 💚 Build #19194 succeeded 27935a3
• 💚 Build #19081 succeeded bfe9066
• 💛 Build #18861 was flaky 9ec4edc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[drewdaemon]

@ppisljar looks like you're the last code-owner reviewer. Do you feel comfortable signing off on this PR?

[ppisljar]

code LGTM