This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Overrides cgroup path #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The virtual file /proc/self/cgroup should list the current cgroup membership. For each hierarchy, you can follow the cgroup path from this file to the cgroup filesystem (usually /sys/fs/cgroup/) and introspect the statistics for the cgroup for the given hierarchy. Alas, Docker breaks this by mounting the container statistics at the root while leaving the cgroup paths as the actual paths. Therefore, Kibana provides a mechanism to override reading the cgroup path from /proc/self/cgroup and instead uses the cgroup path defined the configuration properties cpu.cgroup.path.override and cpuacct.cgroup.path.override. Therefore, we set this value here so that cgroup statistics are available for the container this process will run in. Signed-off-by: Tyler Smalley <[email protected]>
|
Blocked on elastic/kibana#10402 |
|
elastic/kibana#10402 has been merged so this is ready for review. This will need backported to 5.x |
|
Thanks @tylersmalley. Which versions will this apply to? Is it for all 5.x versions? |
|
This should target 5.4, 5.x and 6.0 (master) |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to elastic/elasticsearch-docker#25 we need to override the cgroup cpu and cpuacct paths.