Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2] Benchmark message serialization latency for v0.2.0 release #26

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

orecham
Copy link
Contributor

@orecham orecham commented Feb 17, 2025

Notes for Reviewer

  1. A number of tweaks to ensure no regression in communication latency
  2. Update benchmarking scripts to:
    1. Include a flag to switch between self-contained and non-self-contained message types
    2. Plot different benchmarking results (identified by directory) on a single figure
  3. Update the README to highlight the impact serialization of non-self-contained messages has on communication latency

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (rmw-iox2-123-implement-graph-api)
  • Commit messages have the issue ID ([#123] Add posix ipc example)
  • Tests exist for new behavior
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@orecham orecham self-assigned this Feb 17, 2025
elBoberido
elBoberido previously approved these changes Mar 6, 2025
Comment on lines +19 to +20
// Try to get handle from current type support
if (auto ts = get_message_typesupport_handle(next, identifier); ts) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: the comment mentions current but the variable is called next. What do you think about also using current for the variable name?

@orecham orecham force-pushed the rmw-iox2-2-benchmark-message-serialization branch from cfd1dfc to cd2f85e Compare March 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants