Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove support for V1 Events #889

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

SDK has temporary support for V1 Events which get converted to V2 Events

Issue Number: #884

What is the new behavior?

Support for V1 Events has been removed

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell linked an issue Jun 9, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #889 (4bf66b1) into master (69a9f95) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   64.14%   63.82%   -0.32%     
==========================================
  Files          32       32              
  Lines        2139     2101      -38     
==========================================
- Hits         1372     1341      -31     
+ Misses        674      671       -3     
+ Partials       93       89       -4     
Impacted Files Coverage Δ
internal/runtime/runtime.go 72.30% <ø> (-2.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a9f95...4bf66b1. Read the comment docs.

@lenny-goodell lenny-goodell merged commit d651532 into edgexfoundry:master Jun 9, 2021
@lenny-goodell lenny-goodell deleted the remove-v1-event branch June 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK: Remove V1 Event support
3 participants