-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove V1 API code and swagger #730
refactor: Remove V1 API code and swagger #730
Conversation
Also reworked V2 code to remove `v2` in paths closes #720 BREAKING CHANGE: V1 API's no longer supported Signed-off-by: lenny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny tweaks
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 64.64% 63.30% -1.35%
==========================================
Files 32 32
Lines 2110 2060 -50
==========================================
- Hits 1364 1304 -60
- Misses 652 664 +12
+ Partials 94 92 -2
Continue to review full report at Codecov.
|
Signed-off-by: lenny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but build failed
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
V1 Api code and swagger exist
Issue Number: #720
What is the new behavior?
V1 Api code and swagger no longer exist
Also reworked V2 code to remove
v2
in pathsDoes this PR introduce a breaking change?
BREAKING CHANGE: V1 API's no longer supported
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information