feat: fix logic to better error handling when common config is missing when runs in hybrid mode #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g when runs in hybrid mode Closes: edgexfoundry#1443 Signed-off-by: Jim Wang <[email protected]>
|
on DRAFT mode until the version of go-mod-bootstrap in go.mod includes the issue fixed for the PR |
Signed-off-by: Jim Wang <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1444 +/- ##
==========================================
- Coverage 66.83% 66.76% -0.08%
==========================================
Files 36 36
Lines 3088 3093 +5
==========================================
+ Hits 2064 2065 +1
- Misses 891 893 +2
- Partials 133 135 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with better error message handling from the go-mod-bootstrap PR, there is some logic needs to be fixed to avoid the app being crashed.
Closes: #1443
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)
relate to go-mod-bootstrap issue when common config is missing from command line.