Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk): remove deprecated StoreSecret code #1254

Merged
merged 1 commit into from
Jan 10, 2023
Merged

refactor(sdk): remove deprecated StoreSecret code #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions internal/app/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,12 +575,6 @@ func (svc *Service) ListenForCustomConfigChanges(configToWatch interface{}, sect
return nil
}

// StoreSecret stores the secret data to a secret store at the specified path.
func (svc *Service) StoreSecret(path string, secretData map[string]string) error {
secretProvider := bootstrapContainer.SecretProviderFrom(svc.dic.Get)
return secretProvider.StoreSecret(path, secretData)
}

// SecretProvider returns the SecretProvider instance
func (svc *Service) SecretProvider() bootstrapInterfaces.SecretProvider {
secretProvider := bootstrapContainer.SecretProviderFrom(svc.dic.Get)
Expand Down
14 changes: 0 additions & 14 deletions pkg/interfaces/mocks/ApplicationService.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions pkg/interfaces/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,6 @@ type ApplicationService interface {
// asynchronously to the Edgex MessageBus on the specified topic.
// Not valid for use with the HTTP or External MQTT triggers
AddBackgroundPublisherWithTopic(capacity int, topic string) (BackgroundPublisher, error)
// StoreSecret stores the specified secret data into the secret store (secure only) for the specified path
// An error is returned if:
// - Specified secret data is empty
// - Not using the secure secret store, i.e. not valid with InsecureSecrets configuration
// - Secure secret provider is not properly initialized
// - Connection issues with Secret Store service.
StoreSecret(path string, secretData map[string]string) error // LoggingClient returns the Logger client
// SecretProvider returns the SecretProvider instance
SecretProvider() bootstrapInterfaces.SecretProvider
// LoggingClient returns the Logger client
Expand Down