fix: Skip compatibility check when Core Data's version is 0.0.0 (deve…

…loper build) (#533) closes #532 Signed-off-by: lenny <[email protected]>
edgexfoundry · Oct 9, 2020 · 35ab7bc · 35ab7bc
1 parent 15f2541
commit 35ab7bc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/internal/bootstrap/handlers/version.go b/internal/bootstrap/handlers/version.go
@@ -34,6 +34,7 @@ import (
 
 const (
 	CorePreReleaseVersion = "master"
+	CoreDeveloperVersion  = "0.0.0"
 	CoreServiceVersionKey = "version"
 	VersionMajorIndex     = 0
 )
@@ -118,7 +119,15 @@ func (vv *VersionValidator) BootstrapHandler(
 		logger.Info(
 			"Skipping version compatibility check for Core Pre-release version",
 			"version",
-			internal.SDKVersion)
+			coreVersion)
+		return true
+	}
+
+	if coreVersion == CoreDeveloperVersion {
+		logger.Info(
+			"Skipping version compatibility check for Core Developer version",
+			"version",
+			coreVersion)
 		return true
 	}
 

diff --git a/internal/bootstrap/handlers/version_test.go b/internal/bootstrap/handlers/version_test.go
@@ -86,6 +86,7 @@ func TestValidateVersionMatch(t *testing.T) {
 		{"SDK Beta Version", "1.0.0", "v0.2.0", false, false},
 		{"SDK Version malformed", "1.0.0", "", false, true},
 		{"Core prerelease version", CorePreReleaseVersion, "v1.0.0", false, false},
+		{"Core developer version", CoreDeveloperVersion, "v1.0.0", false, false},
 		{"Core version malformed", "12", "v1.0.0", false, true},
 		{"Core version JSON bad", "", "v1.0.0", false, true},
 		{"Core version JSON empty", "{}", "v1.0.0", false, true},