GH-5277 Add check for geospatial lucene answers #5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You took care of my previous Lucene PR, can you get a look at this one @hmottestad? |
hmottestad
reviewed
Mar 31, 2025
Comment on lines
+871
to
+874
| } else if (GEOF.EH_COVERED_BY.stringValue().equals(relation)) { | ||
| return GEOF.SF_WITHIN; | ||
| } else if (GEOF.EH_COVERS.stringValue().equals(relation)) { | ||
| return GEOF.EH_CONTAINS; |
There was a problem hiding this comment.
Seems that everything else maps to itself expect for these two. Could you add a comment explaining why?
There was a problem hiding this comment.
The problem with this part is similar to this check:
Which is badly made and would require another issue/pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5277
Briefly describe the changes proposed in this PR:
I have added a validation step before returning the geometries obtained by the search index. This step is done by reusing the
rdf4j-queryalgebra-geosparqlfunctions.PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)