Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface for reading config options from the client after initialization. #87

Merged
merged 2 commits into from
Apr 5, 2017

Conversation

aleksclark
Copy link
Contributor

Should close #5

Signed-off-by: Aleks Clark [email protected]

@alsm
Copy link
Contributor

alsm commented Mar 31, 2017

Thanks for working on this, copying the contents of the struct before returning should stop anything inside the client from being edited while in use, except for the Store, Store is an interface, and for example the default memory store is passed into the ClientOptions as a pointer, so returning that would actually pass back the instance of the Store in use and allow someone to (stupidly I admit, you wouldnt ever want to) call the exported interface functions. I'm not sure if Store needs to be visible for clients once initialised?

@aleksclark aleksclark force-pushed the bug-5-client-options-reader branch from bacfe20 to 1ef804f Compare April 1, 2017 11:07
@aleksclark
Copy link
Contributor Author

@alsm got it, thanks

@alsm alsm merged commit 69afaac into eclipse-paho:master Apr 5, 2017
@apple314159
Copy link

See issue #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide ability to retrieve options used to create client
3 participants