Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): exit simulation if output configuration is erroneous #478

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hoelger
Copy link
Contributor

@hoelger hoelger commented Mar 10, 2025

Description

Changes the error handling into the direction of "fail early and hard" when the output is not well configured. This might lead to bigger discussions in the group, but I think

Issue(s) related to this PR

  • Resolves internal issue 977

Affected parts of the online documentation

No

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab changed the title 977 statistics enhancements fix(output): exit simulation if output configuration is erroneous Mar 11, 2025
@hoelger hoelger force-pushed the 977-statistics-enhancements branch from 05703f7 to 506316b Compare March 18, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant