Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE after applying the refactoring session #7459

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Prevent NPE after applying the refactoring session #7459

merged 3 commits into from
Nov 22, 2017

Conversation

vzhukovs
Copy link
Contributor

What does this PR do?

Fix an issue with apply refactoring session. After applying the session server responses with bunch of changes (type, old path, new path), but in changes there a may be en nullable change, so this PR adds additional check for null in refactoring updater component.

Back port of #7458

Signed-off-by: Vladyslav Zhukovskyi [email protected]

What issues does this PR fix or reference?

#4979

Changelog

Prevent NPE after applying the refactoring session

Release Notes

N/A

Docs PR

N/A

@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. team/plugin labels Nov 20, 2017
@vzhukovs vzhukovs added this to the 6.0.0-M2 milestone Nov 20, 2017
@vzhukovs vzhukovs self-assigned this Nov 20, 2017
@vzhukovs vzhukovs requested a review from ashumilova November 20, 2017 14:03
@vzhukovs vzhukovs added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 20, 2017
@vzhukovs
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

@vzhukovs vzhukovs merged commit 73e4a28 into che6 Nov 22, 2017
@vzhukovs vzhukovs deleted the che6#4979 branch November 22, 2017 12:29
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants