Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

feat: don't add merge-contribution attribute into the dev container #755

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

svor
Copy link
Contributor

@svor svor commented Jun 28, 2023

What does this PR do?

Update the generator to avoid adding controller.devfile.io/merge-contribution attribute into the developer container, it will be done by the DWO

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22155

How to test this PR?

1/ Go to che-devfile-registry/tools/devworkspace-generator
2/ Build the tool by running yarn
3/ Generate a devworkspace:

node lib/entrypoint.js \
        --devfile-url:https://github.com/che-samples/java-spring-petclinic/tree/main \
        --plugin-registry-url:https://che-plugin-registry-main.surge.sh/v3/ \
        --editor-entry:che-incubator/che-code/latest \
        --output-file:/tmp/devworkspace-che-code-latest.yaml 

4/ Take a look at the generated file /tmp/devworkspace-che-code-latest.yaml, it should not contain controller.devfile.io/merge-contribution attribute in the components.

5/ Try to start a workspace using generated file by executing oc apply -f /tmp/devworkspace-che-code-latest.yaml, workspace should be started.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@svor svor requested review from dmytro-ndp and artaleks9 June 28, 2023 12:46
@svor svor self-assigned this Jun 28, 2023
@svor svor requested review from vinokurig and ibuziuk as code owners June 28, 2023 12:46
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@ibuziuk ibuziuk removed the request for review from dmytro-ndp June 28, 2023 13:05
Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested according to the provided description

@artaleks9
Copy link

Tested according to the provided description.
Approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants