This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
feat: don't add merge-contribution attribute into the dev container #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the generator to avoid adding controller.devfile.io/merge-contribution attribute into the developer container, it will be done by the DWO
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#22155
How to test this PR?
1/ Go to che-devfile-registry/tools/devworkspace-generator
2/ Build the tool by running yarn
3/ Generate a devworkspace:
4/ Take a look at the generated file /tmp/devworkspace-che-code-latest.yaml, it should not contain controller.devfile.io/merge-contribution attribute in the components.
5/ Try to start a workspace using generated file by executing
oc apply -f /tmp/devworkspace-che-code-latest.yaml
, workspace should be started.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.