Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask to start a workpspace from the default devfile, if the factory URL is unsupported #754

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

  • Improve the error when the Factory URL is not supported or restricted.
  • Ask to create a workspace from the default devfile.

What issues does this PR fix or reference?

eclipse-che/che#21997

Is it tested? How?

  1. Deploy che via the test image: chectl server:deploy -p=minikube -i=quay.io/ivinokur/che-server:next
    For the testing purpose I disabled gitlab factory handler in the image.
  2. Apply the dashboard changes.
  3. Pass a gitlab public repo with a devfile to start a workspace e.g. 'https://gitlab.com/ivinokur/test.git'
  4. See the specific error:
    screenshot-localhost_8080-2023 03 10-14_06_55

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Mar 10, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-754

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #754 (248a02f) into main (093840c) will decrease coverage by 0.08%.
The diff coverage is 11.11%.

❗ Current head 248a02f differs from pull request most recent head 3226c50. Consider uploading reports for the commit 3226c50 to get more accurate results

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   77.71%   77.64%   -0.08%     
==========================================
  Files         317      317              
  Lines       31080    31116      +36     
  Branches     1850     1852       +2     
==========================================
+ Hits        24155    24159       +4     
- Misses       6874     6906      +32     
  Partials       51       51              
Flag Coverage Δ
unittests 77.64% <11.11%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...iners/Loader/Factory/Steps/Fetch/Devfile/index.tsx 79.34% <11.11%> (-6.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@che-bot
Copy link
Contributor

che-bot commented Mar 14, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Mar 14, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-754

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-754

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 29164d1 into main Mar 15, 2023
@vinokurig vinokurig deleted the che-21997 branch March 15, 2023 11:19
@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/220: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.63 milestone Mar 15, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2498: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/220: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2743 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1157: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: sync-to-downstream_3.x/2744: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2580 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.6 :: operator-bundle_3.x/1019: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2744 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/726: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.6 :: update-digests_3.x/2498: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/1019 triggered

@devstudio-release
Copy link

Build 3.6 :: dsc_3.x/726: SUCCESS

3.6.0 CI

@devstudio-release
Copy link

Build 3.6 :: copyIIBsToQuay/1157: SUCCESS

3.6
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.6-117
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.19-4
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-453287-440885-ppc64le
  + quay.io/devspaces/iib:3.6-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.6-v4.12-453277-440880-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-453798-440871-ppc64le
  + quay.io/devspaces/iib:3.6-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-453795-440866-ppc64le
  + quay.io/devspaces/iib:3.6-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-453287-440885-s390x
  + quay.io/devspaces/iib:3.6-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.6-v4.12-453277-440880-s390x
  + quay.io/devspaces/iib:3.6-v4.11-453798-440871-s390x
  + quay.io/devspaces/iib:3.6-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.6-v4.10-453795-440866-s390x
  + quay.io/devspaces/iib:3.6-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.6-v4.13-453287-440885-x86_64
  + quay.io/devspaces/iib:3.6-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.6-v4.12-453277-440880-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-453798-440871-x86_64
  + quay.io/devspaces/iib:3.6-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-453795-440866-x86_64
  + quay.io/devspaces/iib:3.6-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/221: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

ScrewTSW pushed a commit to ScrewTSW/che-dashboard that referenced this pull request Jul 14, 2023
…L is unsupported (eclipse-che#754)

Improve the error when the Factory URL is not supported or restricted.
Ask to create a workspace from the default devfile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants