-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask to start a workpspace from the default devfile, if the factory URL is unsupported #754
Conversation
…L is unsupported Signed-off-by: Igor Vinokur <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-754 |
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 77.71% 77.64% -0.08%
==========================================
Files 317 317
Lines 31080 31116 +36
Branches 1850 1852 +2
==========================================
+ Hits 24155 24159 +4
- Misses 6874 6906 +32
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…tory URL is unsupported
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-754 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-754 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.6 :: dashboard_3.x/220: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2743: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1961: Console, Changes, Git Data |
Build 3.6 :: get-sources-rhpkg-container-build_3.x/2579: dashboard : 3.x :: Build 51343040 : quay.io/devspaces/dashboard-rhel8:3.6-24 |
Build 3.6 :: update-digests_3.x/2498: Console, Changes, Git Data |
Build 3.6 :: dashboard_3.x/220: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2743 triggered |
Build 3.6 :: operator-bundle_3.x/1019: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2744: Console, Changes, Git Data |
Build 3.6 :: push-latest-container-to-quay_3.x/1962: Console, Changes, Git Data |
Build 3.6 :: copyIIBsToQuay/1157: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2744: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2580 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.6 :: operator-bundle_3.x/1019: Upstream sync done; /DS_CI/sync-to-downstream_3.x/2744 triggered |
Build 3.6 :: dsc_3.x/726: Console, Changes, Git Data |
Build 3.6 :: update-digests_3.x/2498: Detected new images: rebuild operator-bundle |
Build 3.6 :: dsc_3.x/726: 3.6.0 CI |
Build 3.6 :: dashboard_3.x/221: Console, Changes, Git Data |
Build 3.6 :: sync-to-downstream_3.x/2750: Console, Changes, Git Data |
…L is unsupported (eclipse-che#754) Improve the error when the Factory URL is not supported or restricted. Ask to create a workspace from the default devfile.
What does this PR do?
What issues does this PR fix or reference?
eclipse-che/che#21997
Is it tested? How?
For the testing purpose I disabled gitlab factory handler in the image.
Release Notes
Docs PR