Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace o.e.gef.editparts.ZoomListener with o.e.draw2d.zoom.ZoomListener #2031

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

merks
Copy link
Contributor

@merks merks commented Jan 20, 2025

No description provided.

@merks merks self-assigned this Jan 20, 2025
@merks merks merged commit 661e1a5 into eclipse-birt:master Jan 20, 2025
3 checks passed
@merks merks deleted the pr-gef-zoom-listener branch January 20, 2025 09:50
@merks
Copy link
Contributor Author

merks commented Jan 20, 2025

@speckyspooky

FYI, this was the reason for the failure of the master branch build.

@speckyspooky
Copy link
Contributor

Thanks for the fix!
Was it luck that you now exactly the change and what you have to do or had you others issues too that you know it.

@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Jan 20, 2025
@speckyspooky speckyspooky added this to the 4.19 milestone Jan 20, 2025
@merks
Copy link
Contributor Author

merks commented Jan 20, 2025

The build builds against GEF’s latest build so when GEF removes a deprecated method we notice immediately. It’s a bit painful but better sooner rather than later.

@speckyspooky
Copy link
Contributor

Sounds really special. Very good that the fixed could be done so fast from your side :o)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants