-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intel Parallel Studio 2016, update 1 #2148
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
|
||
toolchain = {'name': 'dummy', 'version': 'dummy'} | ||
|
||
sources = ['parallel_studio_xe_%(version_major)s_composer_edition_for_cpp_%(version)s.tgz'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, the tarball still only has 2016
, the same as the previous release?
please tell me that's not the case...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, no, you have both %(version_major)s
and %(version)s
in there, nevermind :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sources = ['parallel_studio_xe_%(version_major)s_composer_edition_for_cpp_update%(version_minor)s.tgz']
@jas02: please add an HPL easyconfig that uses this new toolchain? |
easyblock = "Toolchain" | ||
|
||
name = 'intel' | ||
version = '2016.00' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, not sure if this is the best version, maybe we should stick to 2016.1.150
?
that is: the first update of the 2016 version of these tools; the 150
part comes back in the impi
and imkl
versions to indicate that all of these 'match'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impi
is in version 5.1.2.150 (update 2). Other components of intel toolchain are update1. So, there is not consistency from Intel side.
This is just maintenance release, changing every time release of toolchain is not what our users want, I think. They want to use latest updated versions of all Intel tools, but in familiar toolchain name (intel-2016.00). What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I see your point. The .00
just seems weird to me, what does that mean? initial release?
I don't feel really strongly about it, just as long as we can motivate whatever we come up with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, but this isn't the initial release, this is update 1, so it should be 2016.01
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used convention from #1973. You had no objections against naming convention and I thought that it will be new toolchain name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, except that #1973 deals with icc/ifort 2016.0.109, while here you have 2016.1.150... The bump in the compiler version should be reflected in the toolchain version, no?
Now both this PR and #1973 propose to use 2016.00
... We want to support installing both the 2016.0.109 and 2016.1.150 versions (for benchmarking/testing, for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, how to solve it? Should I rename version to 2016.01
? And every other "major" update will be increment of this number? We have to be consistent in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 2016.01
makes sense to me, but we can discuss this during the conf call this week (I'll fix the date/time for that ASAP).
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5060/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@jas02 do these work? You need changes in the easyblock? I'm gonna try to fixes the easyblock using easybuilders/easybuild-easyblocks#691 and your current branch. |
'tar xvzf %(installdir)s/mkl/examples/examples_core_c.tgz -C %(installdir)s/mkl/examples/', | ||
'tar xvzf %(installdir)s/mkl/examples/examples_core_f.tgz -C %(installdir)s/mkl/examples/', | ||
'tar xvzf %(installdir)s/mkl/examples/examples_f95.tgz -C %(installdir)s/mkl/examples/', | ||
'tar xvzf %(installdir)s/mkl/examples/examples_mic.tgz -C %(installdir)s/mkl/examples/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, it would be better to handle this via the imkl easyblock (do-once-and-forget)? thoughts @jas02?
fix toolchain version to intel/2016.01, use upstream tarball names, add HPL easyconfig
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5136/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Jenkins: test this please |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5208/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
will be merged via #2219 |
Updated version of Intel Parallel Studio 2016 packages.