fix(virtual-background-guide): updated virtual background guide to support v2 changes #390
Conversation
Deploying dyte-docs with
|
| Latest commit: |
e0eb7ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92117ad9.dyte-docs.pages.dev |
| Branch Preview URL: | https://fix-virtal-background-guide.dyte-docs.pages.dev |
|
|
||
| ```js | ||
| const videoBackgroundTransformer = await DyteVideoBackgroundTransformer.init(); | ||
| await meeting.self.setVideoMiddlewareGlobalConfig({ disablePerFrameCanvasRendering: true }); |
There was a problem hiding this comment.
We don't need this now do we
There was a problem hiding this comment.
2.0.1 & 2.0.2 still require this line to be added by the devs. 2.0.3 onwards, we are internally doing this.
I have kept it here for reference. Also calling this method multiple times is safe and doesn't cause any side effects.
There was a problem hiding this comment.
maybe add a note saying not required post 2.0.3?
There was a problem hiding this comment.
It is added exclusively to highlight it as a breaking change for any custom middlewares that our clients might have.
If any middleware is broken, migration could be done by referring to company branding sample.
Default middleware design: https://github.com/dyte-in/streams-middleware-samples/blob/main/video/company-branding.js
Design if per frame rendering is disabled: https://github.com/dyte-in/streams-middleware-samples/blob/main/video/middleware-with-per-frame-rendering-disabled/company-branding.js
Description
Updated virtual background guide to support v2 changes.