PR: Create Todo List in Phoenix v1.5.3 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have proof read the |
|
52 pages ... 💭 |
|
Test coverage increased in next PR: #39 (comment) |
SimonLab
reviewed
Jun 2, 2020
Co-authored-by: Simon <[email protected]>
SimonLab
reviewed
Jun 2, 2020
SimonLab
reviewed
Jun 2, 2020
Co-authored-by: Simon <[email protected]>
Co-authored-by: Simon <[email protected]>
SimonLab
reviewed
Jun 2, 2020
SimonLab
reviewed
Jun 2, 2020
|
|
||
| # returns integer value of items where item.status == 0 (not "done") | ||
| def remaining_items(items) do | ||
| Enum.filter(items, fn i -> i.status < 1 end) |> Enum.count() |
There was a problem hiding this comment.
I don't think we need the Enum.filter here as we can use the anonymous function directly in count:
Suggested change
| Enum.filter(items, fn i -> i.status < 1 end) |> Enum.count() | |
| Enum.count(items, fn i -> i.status < 1 end) |
There was a problem hiding this comment.
@SimonLab this is a good improvement/simplification provided we explain that Enum.count/2 can take a "filter" function as it's second param. Otherwise I would leave it as is and let a member of the community suggest the refactor. 👍
Co-authored-by: Simon <[email protected]>
SimonLab
reviewed
Jun 2, 2020
Co-authored-by: Simon <[email protected]>
SimonLab
reviewed
Jun 2, 2020
Co-authored-by: Simon <[email protected]>
|
Thanks @SimonLab 🙌 |
HotategaiDev
added a commit
to HotategaiDev/phoenix-todo-list-tutorial-
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[I think] somebody should have written a beginner friendly Phoenix Todo List Tutorial a long time ago ... a todo list is a gentle introduction to basic "CRUD" apps with a familiar UX. 💭
This PR is a Phoenix implementation of https://github.com/dwyl/javascript-todo-list-tutorial ✅
Many people have found our Phoenix Chat Tutorial useful I expect the same here. 🚀
My reasoning for investing so much time into building a Phoenix (Server Side Rendered) version of the TodoMVC from first principals is that it's an intro to how our App works! 📱