Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phishing update script to use compressed curl #3852

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

not-a-rootkit
Copy link
Collaborator

@not-a-rootkit not-a-rootkit commented Feb 7, 2025

Task/Issue URL: https://app.asana.com/0/1204023833050360/1209337736035708
Tech Design URL:
CC:

Description:

  • The macOS browser has a weekly GitHub Actions workflow that updates the phishing protection data set
  • When migrating workflows to the Apple monorepo, I noticed that this workflow is broken on main and has been for at least three weeks
  • The failure reason is jq: parse error: Invalid numeric literal at line 1, column 12 during the Execute Update Script step
  • See https://github.com/duckduckgo/apple-monorepo-test/actions/workflows/macos_update_phishing_detection_data.yml for workflow runs
  • This is because we recently changed the backend to use gzipped responses by default which curl wasn't respecting.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. bash scripts/update_phishing_detection_data.sh
  2. Ensure data is updated

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as advertised - thanks!

@samsymons samsymons merged commit a553c89 into main Feb 7, 2025
27 checks passed
@samsymons samsymons deleted the tespach/fix-malsite-update-script branch February 7, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants