Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying long URLs on HTML NTP Recent Activity feed #3848

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Feb 7, 2025

Task/Issue URL: https://app.asana.com/0/0/1209351911435697/f

Description:
Update BSK to a version containing C-S-S fix for HTML New Tab Page.

Steps to test this PR:

  1. Launch the app from Xcode.
  2. Open https://deploy-preview-1468--content-scope-scripts.netlify.app
  3. Open New Tab Page. Verify that the long domain name is correctly displayed and burn and favorite icons are visible.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from SabrinaTardio February 7, 2025 15:29
@ayoy ayoy mentioned this pull request Feb 7, 2025
1 task
@ayoy ayoy requested review from samsymons and removed request for SabrinaTardio February 7, 2025 15:55
@ayoy ayoy assigned samsymons and unassigned SabrinaTardio Feb 7, 2025
@ayoy ayoy merged commit fc35cc7 into release/1.125.0 Feb 7, 2025
36 of 39 checks passed
@ayoy ayoy deleted the dominik/fix-ntp-long-domains branch February 7, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants