quick fix for allowlist crash #3846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/0/1209150257377771/f ## Description Changes in this PR: - Re-organizes the Status View submenu - Updates titles to remove the "..." suffix - Adds exclusions to the VPN Status View submenu ## Translations Translation Job is [here](https://dashboard.smartling.com/app/projects/f767cb116/account-jobs/f767cb116:kcvr3syqw1nh).
Task/Issue URL: https://app.asana.com/0/0/1209328755192084/f Description: This change updates History Menu to only display one item per URL per day, which is in line with other mainstream browsers. This change remains behind historyView feature flag and will only be made available when Full History View is released. The grouping logic was extracted into HistoryGroupingProvider class where it's made dependent on the feature flag state. Current behavior remains unchanged, as evidenced by added unit tests.
…en history view is enabled (#3833) Task/Issue URL: https://app.asana.com/0/72649045549333/1209328755192085 Description: This change updates History Menu when historyView feature flag is enabled, to only keep history items for last 7 days, and offer opening Full History View in order to view all history. For testing purposes, History Debug Menu was added, where history can be populated with visits to fake websites.
Task/Issue URL: https://app.asana.com/0/1199333091098016/1209334737154919 Tech Design URL: CC: **Description**: This PR disables a failing integration test.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1209158005098852/f Tech Design URL: https://app.asana.com/0/1206329551987282/1209133564224796/f **Description**: Integrate Malicious Site Protection changes as part of the iOS work. During iOS Ship Review we changed copy title for settings. I will double check if these changes needs to be integrated in this PR. **Optional E2E tests**: - [] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. **Steps to test this PR**: 1. Ensure CI is green *Before Merging* * [ ] Update BSK Reference. * [x] Merge String Localizations (TBC). **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Task/Issue URL: https://app.asana.com/0/1206873150423133/1209329833070078 Tech Design URL: CC: **Description**: Fixes the PeopleWhiz selector which was appending extra text to the name and causing matches to fail. **Optional E2E tests**: - [x] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. **Steps to test this PR**: 1. Load into macOS, test in the debugger <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Task/Issue URL: https://app.asana.com/0/1204186595873227/1209311973888722 **Description**: Restart onboarding experiment with contextual onboarding
Task/Issue URL: https://app.asana.com/0/1187352151074490/1209334604294772 Tech Design URL: CC: **Description**: Adds an empty and inert package for now to aid migration. See TD for details **Optional E2E tests**: - [x] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. **Steps to test this PR**: 1. Test macOS still compiles and runs <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Pete Smith <[email protected]>
Task/Issue URL: https://app.asana.com/0/1206580121312550/1209309062840626/f ## Description See [Figma](https://www.figma.com/design/y7g8d3Nuefhfedq4638Rhu/VPN%3A-Domain-and-App-exclusions-on-Windows?node-id=134-18153&p=f&m=dev) for reference (keep in mind this is a Windows Figma, and there's no macOS one). Changes: - When a routing-rule is applied to an app through the VPN, its embedded binaries will be subjected to the same rules.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1209322889682604/f iOS PR: duckduckgo/iOS#3928 BSK PR: duckduckgo/BrowserServicesKit#1213 **Description**: Fixes an issue where the tunnel is being stopped twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204186595873227/1209345938720177:
Description: Decreases the chance that allowlist is modified in another thread while used in the contentBlockerRulesLists getter. We should follow up with making the allowlist actually thread safe. But this can quickly be merged in the release branch while we make the other changes in BSK.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation