Privacy Pro Free Trials - BSK Bump (No macOS Functional Changes) #3838
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miasma13
approved these changes
Feb 7, 2025
|
@federicocappelli Nothing actionable for you, just mentioning so you are aware of these upcoming changes. |
aataraxiaa
force-pushed
the
pete/pp-free-trials-status
branch
from
96e7f6c to
ece95d3
Compare
aataraxiaa
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 10, 2025
…1218) Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1206488453854252/1209235370800483 iOS PR: duckduckgo/iOS#3936 macOS PR: duckduckgo/macos-browser#3838 What kind of version bump will this require?: Patch **Description**: To support Free Trials in the iOS app, adding `Offer` Model and `activeOffers` Property. **Steps to test this PR**: 1. See client PRs --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206488453854252/1209235370800483
Description: BSK Bump (No macOS Functional Changes)
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation