Skip to content

Commit

Permalink
Update with resubmission information for 0.1.0
Browse files Browse the repository at this point in the history
0.1.0 was initially rejected because of plotly/plotly.R#1906. This updates the cran-comments.md now that this is resolved. This also ignores the CRAN-RELEASE file that was created as part of that submission, and updates the README to include a CRAN badge.
  • Loading branch information
dschafer committed Jan 15, 2021
1 parent 3840de3 commit 7631f8f
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ cran-comments.md
^\.lintr$
^\.github$
^codecov\.yml$
^CRAN-RELEASE$
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
CRAN-RELEASE
inst/doc
.Rproj.user
.Rhistory
Expand Down
1 change: 1 addition & 0 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ knitr::opts_chunk$set(
# activatr

<!-- badges: start -->
[![CRAN status](https://www.r-pkg.org/badges/version/activatr)](https://cran.r-project.org/package=activatr)
[![R-CMD-check](https://github.com/dschafer/activatr/workflows/R-CMD-check/badge.svg)](https://github.com/dschafer/activatr/actions)
[![Codecov test coverage](https://codecov.io/gh/dschafer/activatr/branch/master/graph/badge.svg)](https://codecov.io/gh/dschafer/activatr?branch=master)
<!-- badges: end -->
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

<!-- badges: start -->

[![CRAN
status](https://www.r-pkg.org/badges/version/activatr)](https://cran.r-project.org/package=activatr)
[![R-CMD-check](https://github.com/dschafer/activatr/workflows/R-CMD-check/badge.svg)](https://github.com/dschafer/activatr/actions)
[![Codecov test
coverage](https://codecov.io/gh/dschafer/activatr/branch/master/graph/badge.svg)](https://codecov.io/gh/dschafer/activatr?branch=master)
Expand Down
3 changes: 3 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## Resubmission
This is a resubmission. The previous version had a WARNING because plotly was orphaned -- this was reported at https://github.com/ropensci/plotly/issues/1906 and has now been resolved.

## Test environments
* Local OS X install, R 4.0.3, `x86_64-apple-darwin17.0`.
* Windows via `devtools::check_win_devel`.
Expand Down
Binary file modified man/figures/README-basicplot-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-finalplot_run-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-mapplot_run-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 7631f8f

Please sign in to comment.