fix(Http): Auxiliary methods like get, put, post, etc. do not set typ…

…e restriction on data being sent. Fixes dart-archive#1051
dsalsbury · Jul 16, 2014 · f94a9d0 · f94a9d0
1 parent abc3027
commit f94a9d0
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/lib/core_dom/http.dart b/lib/core_dom/http.dart
@@ -424,7 +424,7 @@ class Http {
   async.Future<HttpResponse> call({
     String url,
     String method,
-    data,
+    dynamic data,
     Map<String, dynamic> params,
     Map<String, dynamic> headers,
     bool withCredentials: false,
@@ -458,8 +458,6 @@ class Http {
     });
 
     var serverRequest = (HttpResponseConfig config) {
-      assert(config.data == null || config.data is String || config.data is dom.File);
-
       // Strip content-type if data is undefined
       if (config.data == null) {
         new List.from(headers.keys)
@@ -539,7 +537,6 @@ class Http {
    * of parameters.
    */
   async.Future<HttpResponse> get(String url, {
-    String data,
     Map<String, dynamic> params,
     Map<String, String> headers,
     bool withCredentials: false,
@@ -548,7 +545,7 @@ class Http {
     interceptors,
     cache,
     timeout
-  }) => call(method: 'GET', url: url, data: data, params: params, headers: headers,
+  }) => call(method: 'GET', url: url, data: null, params: params, headers: headers,
              withCredentials: withCredentials, xsrfHeaderName: xsrfHeaderName,
              xsrfCookieName: xsrfCookieName, interceptors: interceptors, cache: cache,
              timeout: timeout);
@@ -558,7 +555,7 @@ class Http {
    * of parameters.
    */
   async.Future<HttpResponse> delete(String url, {
-    String data,
+    dynamic data,
     Map<String, dynamic> params,
     Map<String, String> headers,
     bool withCredentials: false,
@@ -577,7 +574,7 @@ class Http {
    * of parameters.
    */
   async.Future<HttpResponse> head(String url, {
-    String data,
+    dynamic data,
     Map<String, dynamic> params,
     Map<String, String> headers,
     bool withCredentials: false,
@@ -595,7 +592,7 @@ class Http {
    * Shortcut method for PUT requests.  See [call] for a complete description
    * of parameters.
    */
-  async.Future<HttpResponse> put(String url, String data, {
+  async.Future<HttpResponse> put(String url, dynamic data, {
     Map<String, dynamic> params,
     Map<String, String> headers,
     bool withCredentials: false,
@@ -613,7 +610,7 @@ class Http {
    * Shortcut method for POST requests.  See [call] for a complete description
    * of parameters.
    */
-  async.Future<HttpResponse> post(String url, String data, {
+  async.Future<HttpResponse> post(String url, dynamic data, {
     Map<String, dynamic> params,
     Map<String, String> headers,
     bool withCredentials: false,
@@ -632,7 +629,7 @@ class Http {
    * of parameters.
    */
   async.Future<HttpResponse> jsonp(String url, {
-    String data,
+    dynamic data,
     Map<String, dynamic> params,
     Map<String, String> headers,
     bool withCredentials: false,