Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for table comments #50

Merged
merged 9 commits into from
Jun 24, 2023
Merged

Add support for table comments #50

merged 9 commits into from
Jun 24, 2023

Conversation

drwl
Copy link
Owner

@drwl drwl commented Jun 21, 2023

This PR makes the following changes:

  • Adds support for table comments
  • Adds 2 new options keys: with_column_comments and with_table_comments
  • Checks for with_comment: true, with_column_comments: true to add column comments
  • Checks for with_comment: true, with_table_comments: true to add table comments
  • Changes Options#load_defaults, it defaults with_column_comments and with_table_comments to use the value set in with_comment if not previously set

@drwl
Copy link
Owner Author

drwl commented Jun 24, 2023

Credit goes to @suzunedev from ctran/annotate_models#987 for PR inspiration. Addresses ctran/annotate_models#917.

@drwl drwl merged commit 43d2c87 into main Jun 24, 2023
@drwl drwl deleted the drwl/add-table-comments branch June 24, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant