Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set peer state to running when scope size is SizeScope_TINY #1004

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

gaius-qi
Copy link
Member

Description

  • Set peer state to running when scope size is SizeScope_TINY.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Jan 18, 2022
@gaius-qi gaius-qi self-assigned this Jan 18, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner January 18, 2022 03:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #1004 (4d52c0f) into main (71425c6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   45.80%   45.75%   -0.05%     
==========================================
  Files         130      130              
  Lines        9131     9138       +7     
==========================================
- Hits         4182     4181       -1     
- Misses       4480     4485       +5     
- Partials      469      472       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.75% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/peer.go 74.35% <ø> (ø)
scheduler/rpcserver/rpcserver.go 85.51% <0.00%> (-7.72%) ⬇️
scheduler/service/callback.go 68.21% <ø> (+0.90%) ⬆️
pkg/sync/krwmutex.go 81.81% <0.00%> (-4.55%) ⬇️
pkg/sync/kmutex.go 100.00% <0.00%> (+16.66%) ⬆️

@yxxhero yxxhero merged commit 8aecb35 into main Jan 18, 2022
@yxxhero yxxhero deleted the feature/tiny-piece branch January 18, 2022 07:25
gaius-qi added a commit that referenced this pull request Jun 28, 2023
)

* chore: sync docker-compose scheduler config (#1001)

Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Gaius <[email protected]>

* feat: set peer state to running when scope size is SizeScope_TINY

Signed-off-by: Gaius <[email protected]>

Co-authored-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants