Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert codegen and DB setup to Nx tasks #33

Merged
merged 9 commits into from
Feb 18, 2025
Merged

Convert codegen and DB setup to Nx tasks #33

merged 9 commits into from
Feb 18, 2025

Conversation

matejchalk
Copy link
Contributor

@matejchalk matejchalk commented Jan 18, 2025 •
edited
Loading

Follow-up to #32

Replaced complex npm-run-all script with Nx targets, which are now scoped per project and orchestrated in required order.

  • All database configs and tasks are moved to db project.
    graph
  • GraphQL codegen was split into multiple projects, each with their own config. The GraphQL code generation is now cacheable.
    graph (1)
  • Simplified E2E tests in CI, DB is started automatically with minimal requirements (doesn't pull adminer Docker image).

@matejchalk matejchalk changed the title Convert codegen to Nx tasks Convert codegen and DB setup to Nx tasks Feb 8, 2025
@matejchalk matejchalk marked this pull request as ready for review February 8, 2025 22:02
@matejchalk matejchalk self-assigned this Feb 8, 2025
@matejchalk matejchalk added 🧹 maintenance project maintenance 🚀 setup project setup 🛠️ tooling tooling integration and maintenance 🦾 CI/CD continuous integration and deployment labels Feb 8, 2025
@matejchalk matejchalk requested a review from Tlacenka February 8, 2025 22:12
Tlacenka
Tlacenka approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice restructuring and optimisations. 👍

@matejchalk matejchalk merged commit 3dde7c3 into main Feb 18, 2025
6 checks passed
@matejchalk matejchalk deleted the db-nx-graph branch February 18, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tlacenka Tlacenka Tlacenka approved these changes

Assignees

@matejchalk matejchalk

Labels
🦾 CI/CD continuous integration and deployment 🧹 maintenance project maintenance 🚀 setup project setup 🛠️ tooling tooling integration and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejchalk @Tlacenka