Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firebase version to avoid compilation freeze on iOS #460

Closed
wants to merge 1 commit into from
Closed

Fix Firebase version to avoid compilation freeze on iOS #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,14 @@
<source url="https://cdn.cocoapods.org/"/>
</config>
<pods use-frameworks="true">
<pod name="Firebase/Core" spec="6.28.0"/>
<pod name="Firebase/Auth" spec="6.28.0"/>
<pod name="Firebase/Messaging" spec="6.28.0"/>
<pod name="Firebase/Performance" spec="6.28.0"/>
<pod name="Firebase/RemoteConfig" spec="6.28.0"/>
<pod name="Firebase/InAppMessaging" spec="6.28.0"/>
<pod name="FirebaseFirestore" git="https://github.com/invertase/firestore-ios-sdk-frameworks.git" tag="6.28.0"/>
<pod name="Firebase/Crashlytics" spec="6.28.0"/>
<pod name="Firebase/Core" spec="6.28.1"/>
<pod name="Firebase/Auth" spec="6.28.1"/>
<pod name="Firebase/Messaging" spec="6.28.1"/>
<pod name="Firebase/Performance" spec="6.28.1"/>
<pod name="Firebase/RemoteConfig" spec="6.28.1"/>
<pod name="Firebase/InAppMessaging" spec="6.28.1"/>
<pod name="Firebase/Firestore" spec="6.28.1"/>
Copy link
Owner

@dpa99c dpa99c Jul 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pre-compiled version of Firestore needs to be kept as it significantly reduces build times

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pre-compiled version of Firestore needs to be kept as it significantly reduces build times

The pre-compiler firestore version freeze the ios compilation on my side.

Ionic:

Ionic CLI : 6.10.1 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 5.2.3
@angular-devkit/build-angular : 0.1000.3
@angular-devkit/schematics : 10.0.3
@angular/cli : 10.0.3
@ionic/angular-toolkit : 2.2.0

Cordova:

Cordova CLI : 9.0.0 ([email protected])
Cordova Platforms : android 8.1.0, electron 1.1.1, ios 5.1.1
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.1, (and 8 other plugins)

Utility:

cordova-res (update available: 0.15.1) : 0.14.0
native-run : 1.0.0

System:

ios-deploy : 1.10.0
ios-sim : 8.0.2
NodeJS : v12.16.1 (/usr/local/bin/node)
npm : 6.13.4
OS : macOS Catalina
Xcode : Xcode 11.6 Build version 11E708

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example project builds fine for me with [email protected] in Xcode 11.5 and Xcode 12.0 Beta 2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I follow the readme :

git clone https://github.com/dpa99c/cordova-plugin-firebasex-test.git && cd cordova-plugin-firebasex-test
npm install

cordova platform add ios
cordova run ios

I obtain a build failed on the same step i'm freeze on my project :

PhaseScriptExecution [CP]\ Copy\ Pods\ Resources /Users/damienblanchet/Library/Developer/Xcode/DerivedData/FirebaseTest-cqjrdjtdzlwcmiehwgvhhflbbajx/Build/Intermediates.noindex/FirebaseTest.build/Debug-iphonesimulator/FirebaseTest.build/Script-71CBF5A57D83BC59C2384146.sh (in target 'FirebaseTest' from project 'FirebaseTest')
    cd /Users/damienblanchet/Sources/cordova-plugin-firebasex-test/platforms/ios
    /bin/sh -c /Users/damienblanchet/Library/Developer/Xcode/DerivedData/FirebaseTest-cqjrdjtdzlwcmiehwgvhhflbbajx/Build/Intermediates.noindex/FirebaseTest.build/Debug-iphonesimulator/FirebaseTest.build/Script-71CBF5A57D83BC59C2384146.sh
/Users/damienblanchet/Sources/cordova-plugin-firebasex-test/platforms/ios/Pods/FirebaseFirestore/FirebaseFirestore/Resources/gRPCCertificates-Cpp.bundle
error: Resource "/Users/damienblanchet/Library/Developer/Xcode/DerivedData/FirebaseTest-cqjrdjtdzlwcmiehwgvhhflbbajx/Build/Products/Debug-iphonesimulator/FirebaseInAppMessaging/InAppMessagingDisplayResources.bundle" not found. Run 'pod install' to update the copy resources script.

** BUILD FAILED **

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dpa99c/cordova-plugin-firebasex#cordova-cli-builds

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I applied the modifications of this paragraph and I got a build success. I will investigate on my side to try to identify the issue

<pod name="Firebase/Crashlytics" spec="6.28.1"/>
<pod name="GoogleSignIn" spec="5.0.2"/>
<pod name="GoogleTagManager" spec="7.1.2"/>
</pods>
Expand Down