fix(input): handle IME events on input Enter keydown #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I've put up a pull request to add @neet! 🎉 |
silviuaavram
force-pushed
the
fix/ime-composing-on-enter
branch
from
de1f125 to
bc6af26
Compare
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1022 1026 +4
Branches 200 202 +2
=========================================
+ Hits 1022 1026 +4
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.0.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Recreating the fix from #671.
Why:
Handle this case by default in Downshift without users having to create boiler plate handling.
Handle IME composing events.
How:
Check for
event.which === 229. If true, then will wait for a subsequent event without composing.More info on:
mui/material-ui#19435
zendeskgarden/react-components#598
Checklist: