Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Roslyn Analyzers from VS #74941

Closed
arunchndr opened this issue Aug 29, 2024 · 2 comments
Closed

Load Roslyn Analyzers from VS #74941

arunchndr opened this issue Aug 29, 2024 · 2 comments
Assignees
@JoeRobich
Labels
Area-Analyzers Area-IDE
Milestone
17.12

Comments

@arunchndr
Copy link
Member

Refer to dotnet/sdk#42087 and #74775 for context.

The experience for roslyn analyzers is diff than the rest of the .NET SDK analyzers. But it should follow suit with the SDK analyzers.

Also, since this tightens up the load range for the analyzers, this should make it a low risk change to bring into 17.12.

cc: @sharwell to help validate the analyzers functionality and @tmat to get the option and insertion config correct.
@arunchndr arunchndr added this to the 17.12 P3 milestone Aug 29, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 29, 2024
@arunchndr arunchndr added Area-IDE and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 29, 2024
@arunchndr arunchndr changed the title Redirect Roslyn Analyzers to VS Load Roslyn Analyzers from VS Aug 29, 2024
@arunchndr arunchndr modified the milestones: 17.12 P3, 17.12 Oct 28, 2024
@CyrusNajmabadi CyrusNajmabadi modified the milestones: 17.12, 17.13 Nov 26, 2024
@CyrusNajmabadi
Copy link
Member

@JoeRobich @sharwell what is remaining on this? If nothing is remaining, please closeout.

@JoeRobich JoeRobich modified the milestones: 17.13, 17.12 Nov 26, 2024
@JoeRobich
Copy link
Member

Sorry, yes this work is complete. The only future task would be to move the redirection logic from ProjectSystemProject to the analyzer assembly redirection API being added in #74820.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeRobich JoeRobich

Labels
Area-Analyzers Area-IDE
Projects
None yet
Milestone
17.12
Development

No branches or pull requests
3 participants
@JoeRobich @CyrusNajmabadi @arunchndr