Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore line endings in test assertions #18674

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Ignore line endings in test assertions #18674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/EFCore.Relational.Specification.Tests/Query/QueryNoClientEvalTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public virtual void Throws_when_join()
outerKeySelector: i => i,
innerKeySelector: (e1, i) => e1)",
"NavigationExpandingExpressionVisitor"),
message);
message, ignoreLineEndingDifferences: true);
}
}

Expand All @@ -176,7 +176,7 @@ public virtual void Throws_when_group_join()
outerKeySelector: i => i,
innerKeySelector: (e1, g) => e1)",
"NavigationExpandingExpressionVisitor"),
message);
message, ignoreLineEndingDifferences: true);
}
}

Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,7 @@ public virtual async Task Select_navigation_with_concat_and_count(bool isAsync)
Expression: g), ""FullName"") != null && EF.Property<string>((NavigationTreeExpression
Value: (EntityReference: Gear)
Expression: g), ""FullName"") == EF.Property<string>(i, ""OwnerFullName""))))", "NavigationExpandingExpressionVisitor"),
message);
message, ignoreLineEndingDifferences: true);
}

[ConditionalTheory(Skip = "Issue #17068")]
Expand Down Expand Up @@ -1648,7 +1648,7 @@ public virtual async Task Concat_with_collection_navigations(bool isAsync)
Expression: g), ""FullName"") != null && EF.Property<string>((NavigationTreeExpression
Value: (EntityReference: Gear)
Expression: g), ""FullName"") == EF.Property<string>(i, ""OwnerFullName""))))", "NavigationExpandingExpressionVisitor"),
message);
message, ignoreLineEndingDifferences: true);
}

[ConditionalTheory]
Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.Specification.Tests/Query/SimpleQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2597,7 +2597,7 @@ public virtual async Task Default_if_empty_top_level_arg(bool isAsync)
.Where(c => c.EmployeeID == 4294967295)
.DefaultIfEmpty(__p_0)",
"NavigationExpandingExpressionVisitor"),
message);
message, ignoreLineEndingDifferences: true);
}

[ConditionalTheory]
Expand All @@ -2616,7 +2616,7 @@ public virtual async Task Default_if_empty_top_level_arg_followed_by_projecting_
.Where(c => c.EmployeeID == 4294967295)
.DefaultIfEmpty(__p_0)",
"NavigationExpandingExpressionVisitor"),
message);
message, ignoreLineEndingDifferences: true);
}

[ConditionalTheory]
Expand Down