Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeleteBehavior to allow client-only cascades #15311

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

ajcvickers
Copy link
Contributor

Issue #12661

/// <para>
/// Note: it is unusual to use this value. Consider using <see cref="ClientSetNull"/> instead to match
/// the behavior of EF6 with cascading deletes disabled.
/// </para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remarks section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last guidance we had was basically not to use the remarks section, but to instead use multiple paragraphs in the summary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a pass to covert them throughout the code.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this effectively fix #11031 as well?

@ajcvickers
Copy link
Contributor Author

Yep. Forgot to reference it in the commit message.

@ajcvickers ajcvickers force-pushed the RestrictMyBoots0409 branch from 4b9f3b3 to 1f4f956 Compare April 15, 2019 22:40
@ajcvickers ajcvickers merged commit ad62e95 into master Apr 15, 2019
@smitpatel smitpatel deleted the RestrictMyBoots0409 branch April 17, 2019 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants