Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo cleanup 2 #961

Closed
wants to merge 370 commits into from
Closed

typo cleanup 2 #961

wants to merge 370 commits into from

Conversation

nschonni
Copy link
Contributor

No description provided.

@nschonni nschonni changed the title typo: elmenet -> element typo cleanup 2 Jun 29, 2019
@bricelam
Copy link
Contributor

bricelam commented Jul 1, 2019

@nschonni Can you squash these commits? I'm starting to think you're maliciously trying to hack your GitHub stats to obtain a false perception of authority...

image

You're already higher than 6 EF team members on the contributors list thanks to #957

@nschonni
Copy link
Contributor Author

nschonni commented Jul 1, 2019

There is the Squash Merge option in the UI to land it as one commit. I keep the separate because it's easier to rebase out commits if changes are requested

@bricelam
Copy link
Contributor

bricelam commented Jul 1, 2019

lol, no worries. Are you editing from GitHub? I don't even know if you can rebase and squash from the web UI...

@nschonni
Copy link
Contributor Author

nschonni commented Jul 1, 2019

Are you editing from GitHub? I don't even know if you can rebase and squash from the web UI...

No, VS code, but I was talking about this action so you can land it as a single commit if everything looks OK https://github.blog/2016-04-01-squash-your-commits/

@ajcvickers
Copy link
Contributor

Thanks!

@ajcvickers ajcvickers closed this Jul 3, 2019
@nschonni
Copy link
Contributor Author

nschonni commented Jul 3, 2019

@ajcvickers did you mean to close?

@bricelam
Copy link
Contributor

bricelam commented Jul 3, 2019

@nschonni Looks like it got merged via #961 #977

@nschonni
Copy link
Contributor Author

nschonni commented Jul 3, 2019

@bricelam that is this PR and it was closed without merging

@nschonni
Copy link
Contributor Author

nschonni commented Jul 3, 2019

Oh, I see #977

@nschonni
Copy link
Contributor Author

nschonni commented Jul 3, 2019

Looks like a branch was created with all but the first commit from this PR

@nschonni nschonni deleted the typos2 branch July 3, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants