Unpin EF dependencies then grab the latest #10682

dougbu · 2019-05-31T05:30:29Z

partially reverts 58c6772
temporarily moves CoreFx, core-setup and Extensions dependencies
- will update EF Core repo before finalizing this PR

dougbu · 2019-05-31T15:48:19Z

@ajcvickers lots of MusicStore failures in https://dev.azure.com/dnceng/public/_build/results?buildId=206727 Any suggestions?

ajcvickers · 2019-05-31T16:08:13Z

Ah, man. I didn't realize we were still building MusicStore. I will take a look.

dougbu · 2019-05-31T19:26:38Z

@Eilon / @Pilchie / @aspnet/build I'm not sure area-infrastructure makes sense here because the PR's about including EF in this release and testing against what we're shipping. area-platform might be more correct.

But, do we need an area-ef or perhaps area-musicstore label in this repo?

Eilon · 2019-05-31T20:54:20Z

From my perspective:

The area labels are to help make sure the right set of people look at an issue/PR
If area labels are wrong, anyone is free to update them. Updating them will help the Machine Learning system do better in the future.

ajcvickers · 2019-05-31T21:00:57Z

@dougbu Pushed MusicStore fixes

ajcvickers · 2019-05-31T21:19:50Z

@dougbu Note that @smitpatel merged a race condition fix that we may need to take here to get the tests passing reliably.

dougbu · 2019-05-31T23:47:37Z

Failures are now focused on 2 test templates:

Templates.Test.SpaTemplateTest.ReactTemplateTest.ReactTemplate_IndividualAuth_NetCore_LocalDb
Templates.Test.SpaTemplateTest.AngularTemplateTest.AngularTemplate_IndividualAuth_Works_LocalDb

I suspect the template itself needs to be updated to match the latest from EF. @ajcvickers could you please have a look? @ryanbrandenburg is the templates guy if you're not sure about the context.

Separately, the following tests failed only on macOS. Is there a race in these tests?

MusicStore.Controllers.CheckoutControllerTest.AddressAndPayment_RedirectToCompleteWhenSuccessful
MusicStore.Components.CartSummaryComponentTest.CartSummaryComponent_Returns_CartedItems
- Guess it's also possible Sqlite does something odd on macOS, leading at least to this failure

ajcvickers · 2019-06-01T00:03:47Z

@dougbu Will take a look

dougbu · 2019-06-01T05:55:18Z

🆙📅 to rebase on 'master' and see if @smitpatel's fix cleans up the tests

ajcvickers · 2019-06-01T17:40:13Z

@dougbu It looks like all the changes I pushed here have been removed!

dougbu · 2019-06-01T17:54:17Z

@ajcvickers yeah, that was my fault. Fortunately I still had 6cf65d7 on my machine (GitHub lost that commit) and have restored it.

dougbu · 2019-06-01T18:18:09Z

/azp run AspNetCore-ci

azure-pipelines · 2019-06-01T18:18:31Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

dougbu · 2019-06-01T18:19:07Z

/azp run AspNetCore-ci

azure-pipelines · 2019-06-01T18:19:19Z

Azure Pipelines successfully started running 1 pipeline(s).

dougbu · 2019-06-01T19:36:29Z

With the addition of a spurious Libuv test failure, looks like the two tests that failed consistently are still failing:

Templates.Test.SpaTemplateTest.ReactTemplateTest.ReactTemplate_IndividualAuth_NetCore_LocalDb
Templates.Test.SpaTemplateTest.AngularTemplateTest.AngularTemplate_IndividualAuth_Works_LocalDb

ajcvickers · 2019-06-02T00:54:47Z

@dougbu @ryanbrandenburg I can't get the ProjectTemplates tests to run locally, even though everything else in AspNetCore is working. I keep seeing the following, even on master:

CSC : warning CS2008: No source files specified. [C:\aspnet\AspNetCore\src\SiteExtensions\LoggingBranch\LoggingBranch.csproj]
C:\aspnet\AspNetCore\.dotnet\x64\sdk\3.0.100-preview5-011568\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(347,5): warning MSB3026: Could not copy "C:\Users\Arthur\.nuget\packages\runtime.win-x64.microsoft.netcore.app\3.0.0-preview6-27730-01\runtimes\win-x64\lib\netcoreapp3.0\System.Collections.Immutable.dll" to "C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Collections.Immutable.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Collections.Immutable.dll' because it is being used by another process.  [C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj]C:\aspnet\AspNetCore\.dotnet\x64\sdk\3.0.100-preview5-011568\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(347,5): warning MSB3026: Could not copy "C:\Users\Arthur\.nuget\packages\runtime.win-x64.microsoft.netcore.app\3.0.0-preview6-27730-01\runtimes\win-x64\lib\netcoreapp3.0\System.Net.Http.dll" to "C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Net.Http.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Net.Http.dll' because it is being used by another process.  [C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj]C:\aspnet\AspNetCore\.dotnet\x64\sdk\3.0.100-preview5-011568\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(347,5): warning MSB3026: Could not copy "C:\Users\Arthur\.nuget\packages\runtime.win-x64.microsoft.netcore.app\3.0.0-preview6-27730-01\runtimes\win-x64\lib\netcoreapp3.0\System.Linq.Expressions.dll" to "C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Linq.Expressions.dll". Beginning retry 1 in 100ms. The process cannot access the file 'C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Linq.Expressions.dll' because it is being used by another process. The file is locked by: "MSBuild.exe (4244), Windows Defender Antivirus Service (5304)" [C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj]
C:\aspnet\AspNetCore\.dotnet\x64\sdk\3.0.100-preview5-011568\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(347,5): warning MSB3026: Could not copy "C:\Users\Arthur\.nuget\packages\runtime.win-x64.microsoft.netcore.app\3.0.0-preview6-27730-01\runtimes\win-x64\lib\netcoreapp3.0\System.Linq.Expressions.dll" to "C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Linq.Expressions.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Linq.Expressions.dll' because it is being used by another process. The file is locked by: "MSBuild.exe (4244), MSBuild.exe (15428), Windows Defender Antivirus Service (5304)" [C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj]C:\aspnet\AspNetCore\.dotnet\x64\sdk\3.0.100-preview5-011568\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ComposeStore.targets(347,5): warning MSB3026: Could not copy "C:\Users\Arthur\.nuget\packages\runtime.win-x64.microsoft.netcore.app\3.0.0-preview6-27730-01\runtimes\win-x64\lib\netcoreapp3.0\System.Linq.Expressions.dll" to "C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Linq.Expressions.dll". Beginning retry 1 in 1000ms. The process cannot access the file 'C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs\win-x64\x64\netcoreapp3.0\System.Linq.Expressions.dll' because it is being used by another process. The file is locked by: "MSBuild.exe (15428), Windows Defender Antivirus Service (5304)" [C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj]C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\rs.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting3.0.0-dev was not found. An approximate best match of Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
C:\aspnet\AspNetCore\artifacts\obj\LoggingBranch\Debug\net461\se\Microsoft.AspNetCore.AzureAppServices.HostingStartup\HostingStartup.csproj : error NU1603: Microsoft.AspNetCore.AzureAppServicesIntegration 3.0.0-dev depends on Microsoft.AspNetCore.Hosting (>= 3.0.0-dev) but Microsoft.AspNetCore.Hosting 3.0.0-dev was not found. An approximate best match of
Microsoft.AspNetCore.Hosting 3.0.0-preview-18571-0006 was resolved.
    6 Warning(s)
    9 Error(s)

Time Elapsed 00:01:13.34
msbuild.exe failed with exit code: 1
C:\aspnet\AspNetCore\src\ProjectTemplates>

dougbu · 2019-06-02T07:25:10Z

@ajcvickers is the information in the folder's README.md file helpful?

dougbu · 2019-06-02T07:29:13Z

In particular, run build.cmd -all -pack in the repository root if you haven't already

ajcvickers · 2019-06-02T14:39:51Z

@dougbu Yes, read that and tried that already. Running build -all -pack from the top level results in those errors. Running just build -pack from the top level works fine.

dougbu · 2019-06-02T18:37:40Z

Can you run the template tests after the successful build -pack?

The other possibility would be downloading the ProjectTemplates.E2ETests….binlog file from the Windows_Test_Templates_Logs artifacts of https://dev.azure.com/dnceng/public/_build/results?buildId=208469 (The cross-plat template tests don't seem to produce bin logs for this test group.)

@ryanbrandenburg any ideas?

ajcvickers · 2019-06-02T18:46:06Z

@dougbu I found a way to reproduce the failures locally and I am investigating.

@ryanbrandenburg @dougbu Summary of trying to get the tests to run locally: I found I could get tests to run with build -pack -test at the top level. Anything using -all fails. But doing this at the top-level is very slow, so I looked at the difference when trying to run the tests from src\ProjectTemplates and found if I remove /t:BuildSharedFx from build.cmd at this level, then the build passes, and at least the tests I care about are now running.

dougbu · 2019-06-02T20:31:47Z

@ajcvickers I picked up the latest from 'master' as well as newer EF and AspNetCore packages in my force-push to this branch. Probably won't fix the template tests but avoids conflicts with #10736.

dougbu · 2019-06-02T23:35:02Z

when trying to run the tests from src\ProjectTemplates and found if I remove /t:BuildSharedFx from build.cmd at this level, then the build passes

That makes sense because without a new Shared Fx on your machine, the tests run using the old EF packages.

@aspnet/build and @ryanbrandenburg, once the Shared Fx is built once, is it possible to point the template tests to what was built previously?

- partially reverts 58c6772

…ooling

dougbu · 2019-06-03T16:21:15Z

🆙📅 to pull in the latest

@rynowak @pranavkm @ajaybhargavb should I worry about breaking changes from Blazor or AspNetCore-Tooling ❔

smitpatel · 2019-06-03T16:25:42Z

eng/Versions.props

@@ -49,7 +49,7 @@
    <!-- Only listed explicitly to workaround https://github.com/dotnet/cli/issues/10528 -->
    <MicrosoftNETCorePlatformsPackageVersion>3.0.0-preview6.19279.8</MicrosoftNETCorePlatformsPackageVersion>
    <!-- Packages from aspnet/Blazor -->
-    <MicrosoftAspNetCoreBlazorMonoPackageVersion>0.10.0-preview6.19273.9</MicrosoftAspNetCoreBlazorMonoPackageVersion>
+    <MicrosoftAspNetCoreBlazorMonoPackageVersion>0.10.0-preview7.19303.2</MicrosoftAspNetCoreBlazorMonoPackageVersion>


Is preview7 is correct here?

@natemcmaster ?

ryanbrandenburg · 2019-06-03T16:39:07Z

@dougbu, by point it at what was built previously, you mean within a single machine build the SharedFx, then build/test templates without additional fiddling? If so yes, that should work.

dougbu · 2019-06-03T18:53:10Z

Getting this in because 2nd build attempt was started accidentally and first one showed only a Yarn registry failure and a known-flaky test

ajcvickers · 2019-06-03T18:58:33Z

Thanks for all your help on this @dougbu. Sorry it has been so painful.

dougbu · 2019-06-03T19:00:16Z

Well, we're not done yet 😈. I need to recreate this PR for preview 6 after Tooling and EF Core official builds get new bits into the right darc channel.

ajcvickers · 2019-06-03T19:05:13Z

Okay, 🤞 then.

dougbu mentioned this pull request May 31, 2019

Update Identity tests for EF breaking changes #10660

Merged

dougbu closed this May 31, 2019

dougbu reopened this May 31, 2019

dougbu requested review from ajcvickers and a team May 31, 2019 15:48

Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 31, 2019

ajcvickers approved these changes May 31, 2019

View reviewed changes

dougbu force-pushed the dougbu/reenable.ef branch from 6cf65d7 to 5179ef3 Compare June 1, 2019 05:54

dougbu force-pushed the dougbu/reenable.ef branch from bf4fa77 to 6c8d2bd Compare June 1, 2019 17:53

dougbu mentioned this pull request Jun 1, 2019

[master] Update dependencies from aspnet/AspNetCore-Tooling #10676

Closed

dougbu force-pushed the dougbu/reenable.ef branch from 6c8d2bd to c938a1d Compare June 2, 2019 20:28

dougbu added 2 commits June 3, 2019 08:40

Unpin EF dependencies then grab the latest

a418a77

- partially reverts 58c6772

Grab latest from Blazor, EF Core (thanx @ajcvickers) and AspNetCore-T…

a6d44df

…ooling

dougbu force-pushed the dougbu/reenable.ef branch from c938a1d to a6d44df Compare June 3, 2019 16:18

dougbu mentioned this pull request Jun 3, 2019

[master] Update dependencies from aspnet/AspNetCore-Toolingaspnet/Blazor #10769

Closed

smitpatel reviewed Jun 3, 2019

View reviewed changes

dougbu marked this pull request as ready for review June 3, 2019 18:53

dougbu merged commit 3bb092b into master Jun 3, 2019

ghost deleted the dougbu/reenable.ef branch June 3, 2019 18:54

github-actions bot locked and limited conversation to collaborators Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unpin EF dependencies then grab the latest #10682

Unpin EF dependencies then grab the latest #10682

dougbu commented May 31, 2019

dougbu commented May 31, 2019

ajcvickers commented May 31, 2019

dougbu commented May 31, 2019

Eilon commented May 31, 2019

ajcvickers commented May 31, 2019

ajcvickers commented May 31, 2019

dougbu commented May 31, 2019

ajcvickers commented Jun 1, 2019

dougbu commented Jun 1, 2019

ajcvickers commented Jun 1, 2019

dougbu commented Jun 1, 2019

dougbu commented Jun 1, 2019

azure-pipelines bot commented Jun 1, 2019

dougbu commented Jun 1, 2019

azure-pipelines bot commented Jun 1, 2019

dougbu commented Jun 1, 2019

ajcvickers commented Jun 2, 2019

dougbu commented Jun 2, 2019

dougbu commented Jun 2, 2019

ajcvickers commented Jun 2, 2019

dougbu commented Jun 2, 2019

ajcvickers commented Jun 2, 2019

dougbu commented Jun 2, 2019

dougbu commented Jun 2, 2019

dougbu commented Jun 3, 2019

smitpatel Jun 3, 2019

dougbu Jun 3, 2019

ryanbrandenburg commented Jun 3, 2019

dougbu commented Jun 3, 2019

ajcvickers commented Jun 3, 2019

dougbu commented Jun 3, 2019

ajcvickers commented Jun 3, 2019

Unpin EF dependencies then grab the latest #10682

Unpin EF dependencies then grab the latest #10682

Conversation

dougbu commented May 31, 2019

dougbu commented May 31, 2019

ajcvickers commented May 31, 2019

dougbu commented May 31, 2019

Eilon commented May 31, 2019

ajcvickers commented May 31, 2019

ajcvickers commented May 31, 2019

dougbu commented May 31, 2019

ajcvickers commented Jun 1, 2019

dougbu commented Jun 1, 2019

ajcvickers commented Jun 1, 2019

dougbu commented Jun 1, 2019

dougbu commented Jun 1, 2019

azure-pipelines bot commented Jun 1, 2019

dougbu commented Jun 1, 2019

azure-pipelines bot commented Jun 1, 2019

dougbu commented Jun 1, 2019

ajcvickers commented Jun 2, 2019

dougbu commented Jun 2, 2019

dougbu commented Jun 2, 2019

ajcvickers commented Jun 2, 2019

dougbu commented Jun 2, 2019

ajcvickers commented Jun 2, 2019

dougbu commented Jun 2, 2019

dougbu commented Jun 2, 2019

dougbu commented Jun 3, 2019

smitpatel Jun 3, 2019

Choose a reason for hiding this comment

dougbu Jun 3, 2019

Choose a reason for hiding this comment

ryanbrandenburg commented Jun 3, 2019

dougbu commented Jun 3, 2019

ajcvickers commented Jun 3, 2019

dougbu commented Jun 3, 2019

ajcvickers commented Jun 3, 2019