This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Fix documentation for babel plugin #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the plugin export a variable called |
|
sorry @Swapnull, maybe I didn't so clear... but I had asked you to change to the correct value exported. Change the exported value now I'll result in a break change version, so I think that is better keep the value exported as |
pedronauck
suggested changes
Jun 19, 2018
| @@ -9,7 +9,7 @@ const modifyHappypackLoader = (plugin: any) => { | |||
| plugin.config.loaders[0].loader = require.resolve('babel-loader') | |||
| } | |||
|
|
|||
| export const babel = () => | |||
| @@ -3,7 +3,7 @@ | |||
| By default and by some performance issues, Docz use Babel@7. If you want to use older versions of babel import this plugin and use on your `doczrc.js`: | |||
|
|
|||
| ```js | |||
| import { babel } from 'docz-plugin-babel6' | |||
|
@pedronauck I have changed it back to exporting |
Swapnull
changed the title
pedronauck
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add here a description about your Pull Request
The README for docz-plugin-babel6 currently wont work.
It currently says
But this will result in 'babel6 is not defined'
In this PR I have changed the export name from the plugin to be babel6 as this makes most sense to me.
It would possibly be safer, but may make less sense, to just update the README to either
import { babel as babel6 }plugins[babel()], which is less descriptive.Review