Update Notary framework to use theupdateframework #9
Conversation
|
Ping @cyli @NathanMcCauley |
update.sh
Outdated
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Notary has moved to theupdateframework, so use new base. | |||
There was a problem hiding this comment.
I dont think we need to add this comment.
|
Thanks for the review @justincormack Regards, |
|
Hi Guys, Is there any update w.r.t. work in the direction of support for ARM64? I would be happy to assist if something is required from my side to get Regards, |
|
+1 for this. Please consider it for merge. |
update.sh
Outdated
| mkdir -p $GOPATH/src/github.com/theupdateframework | ||
| cd $GOPATH/src/github.com/theupdateframework/ | ||
| git clone https://github.com/theupdateframework/notary | ||
|
|
There was a problem hiding this comment.
You can't just clone the master branch here. The current assumption is that this is manually built from the right checkout.
There was a problem hiding this comment.
So this means that the user should manually checkout https://github.com/theupdateframework/notary and then build notary code?
Actually, I tried to automate this by fetching all the dependencies for the user who wants to generate binaries for different architectures.
There was a problem hiding this comment.
Yeah that really is not helpful for this repo, that workflow is not going to work, and if it did it would need all the architectures committed as different binaries. The proposal in docker-library/official-images#4718 is that we do release tarballs for more architectures, and use those for building official images.
There was a problem hiding this comment.
Okay got you 😀
Please correct me if I am wrong.
It is sufficient to just update path in this update.sh to use theupdateframework.
And then you will be releasing binaries for ARM64 in the form of tarballs.
Regards,
|
It has been a while, should I update the commit with the changes (just remove clone path) we were discussing or is there any other change which I should commit? Regards, |
- Update Script to use the new officially supported framework. - Update script to fetch the latest code and build binaries according to the host. Signed-off-by: Odidev <[email protected]>
|
@justincormack Regards, |
|
This is fine, but it makes no difference to having official ARM64 support. |
|
Yes, I agree with your concern. However, for the official support, a PR will be required at https://github.com/docker-library/official-images/blob/master/library/notary After this, you will have to upload tarball packages for multiple architectures as mentioned by you in the earlier discussion. Regards, |
|
This is nice update @lag-linaro . |
|
Sure. Looks like the Official Images guys are happy with the current solution. Would you mind closing this PR please? Since I believe that it no longer appropriate. |
|
Hi @lag-linaro Regards, |
|
@odidev just waiting for @justincormack to review #10 |
|
Closing this ticket as AARCH64 on Notary is now an official part of Docker-Hub. |
The changes are verified on both
amd64 & arm64v8architectures.The script generated new static binaries for both architectures and docker was also running fine.
By taking this change, Notary can be extended to
arm64v8architecture as well.