Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java 8 en java 11 images for nanoserver 1809 #291

Closed
wants to merge 3 commits into from

Conversation

esrahofstede
Copy link

@esrahofstede esrahofstede commented Mar 23, 2019

Adding java 8 and 11 images for windows nanoserver 1809
There are currently only Windows Server Core 2016 images available for java 8 and 11.
Since nanoserver is smaller and faster than Windows Server Core, these images bring a better performance.

The images are build multistage, so they are as small as possible.
The verify installer step checks if java and javac can be called from the command line and exists the build process if not found.

@esrahofstede
Copy link
Author

Fixes #293

@tianon
Copy link
Member

tianon commented Mar 29, 2019

See docker-library/official-images#3383 for the discussion around multi-stage builds in the official images program.

@tianon
Copy link
Member

tianon commented Apr 2, 2019

Closing given that this is not something we can reasonably support right now (given our downstream constraints).

If someone wants to maintain this externally with minimal effort, it should theoretically be possible to do COPY --from=openjdk:11-windowsservercore ... or COPY --from=openjdk:11-nanoserver ... (although that's unverified).

@tianon tianon closed this Apr 2, 2019
@esrahofstede
Copy link
Author

Since docker-library/official-images#5929 is merged, can we use multi-stage builds now? The faq is also updated: https://github.com/docker-library/faq#multi-stage-builds

@tianon
Copy link
Member

tianon commented Jul 3, 2019

Fair enough.

I did some experimentation with this, and I'd say it's now blocked on https://bugs.openjdk.java.net/browse/JDK-8218486 / https://bugs.openjdk.java.net/browse/JDK-8225425 (which I ran into immediately after getting an image with Java in it).

@tianon tianon reopened this Jul 3, 2019
@tianon
Copy link
Member

tianon commented Jul 3, 2019

I got it on OpenJDK 8, 11, 13, etc (version doesn't matter -- it seems OpenJDK doesn't actually support Nano Server):

Launching JShell execution engine threw: C:\openjdk-13\bin\net.dll: Can't find dependent libraries

@tianon
Copy link
Member

tianon commented Jul 3, 2019

If anyone wants to play with where I left off, my changes are pushed to master...infosiftr:nanoserver

@tianon
Copy link
Member

tianon commented Sep 6, 2019

Closing this in favor of #293 for tracking the status of Nano Server support in the OpenJDK image instead.

@tianon tianon closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants