Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox-node #5968

Closed
wants to merge 1 commit into from
Closed

Add tox-node #5968

wants to merge 1 commit into from

Conversation

NamsooCho
Copy link

It would be a service.
It serve p2p communication between peers.
It is open sourced project.

@yosifkit
Copy link
Member

yosifkit commented Apr 3, 2020

Apologies for the delays. 🙇‍♂️ New images unfortunately get the least priority but often take the most time to review, so they often fall by the wayside.

Since every change of every image is reviewed by humans, one of the criteria is that new images are "reasonably popular" to be able to get the most out of the available time we have.

In reviewing the project, I'm afraid I don't think it currently fits the criteria of this program. The current Docker Hub image has a small number of pulls and the repos within https://github.com/tox-rs don't yet have much community activity.

We recommend continuing keeping the toxrust/tox-node image up-to-date for your users. We are open to a future discussion


Future considerations:

Unfortunately having the Dockerfile in the code repo (while useful for local development) doesn't work well as the target for official-images. Since the Dockerfile uses ADD . /tox-node, it essentially means the entire tox-node source code is now part of the Docker build context, and thus becomes part of the reviewed artifacts. (see diff-pr.sh for how we generate our diff; it is basically taking all docker build contexts from the starting library/tox-node file and diffing them to the new contexts from the PR). Since you have releases available as .deb, it would make sense to just use those (https://github.com/docker-library/faq/#why-do-so-many-official-images-build-from-source).

Regarding multi-stage builds for official-images, see our FAQ entry on multi-stage builds and the beginning of this comment (docker-library/ghost#209) for my current thoughts.

@yosifkit yosifkit closed this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants