Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): date is not required #235

Merged
merged 6 commits into from
Jun 19, 2023
Merged

fix(changelog): date is not required #235

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
494bd1e
don't parse date
Feverqwe Jun 16, 2023
fc99757
change type
Feverqwe Jun 16, 2023
c258f7f
add tests
Feverqwe Jun 19, 2023
35e3e7b
add parsed changelog count check
Feverqwe Jun 19, 2023
b4f4fcd
only json schema yaml
Feverqwe Jun 19, 2023
4bef785
fix tests
Feverqwe Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix tests
  • Loading branch information
@Feverqwe
Feverqwe committed Jun 19, 2023
commit 4bef78570691fbeb29f2a35def4442fdc82190bb
6 changes: 2 additions & 4 deletions test/changelog.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {Logger} from '../src/transform/log';
import {ChangelogItem} from '../src/transform/plugins/changelog/types';

describe('Changelog', () => {
function getItem(date: Date | undefined, index: number | undefined) {
function getItem(date: string | undefined, index: number | undefined) {
return {
date,
index,
Expand Down Expand Up @@ -59,9 +59,7 @@ describe('Changelog', () => {

expect(html).toBe(`<h1>Some changelog</h1>\n<p>After changelog</p>\n`);

expect(logs).toEqual(
new Array(3).fill(getItem(new Date('2023-05-10T00:00:00.000Z'), undefined)),
);
expect(logs).toEqual(new Array(3).fill(getItem('2023-05-10', undefined)));
});

test('Should cut changelog with index and write it in env', async () => {
Expand Down