Skip to content

dhall-lsp-server: Update to haskell-lsp 0.19 #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2020

Conversation

EggBaconAndSpam
Copy link
Collaborator

As suggested by @sjakobi in #1622.

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Many thanks! :)

@sjakobi
Copy link
Collaborator

sjakobi commented Jan 9, 2020

@EggBaconAndSpam I believe you'll need to update the versions in the stack.yaml too.

@EggBaconAndSpam
Copy link
Collaborator Author

@EggBaconAndSpam I believe you'll need to update the versions in the stack.yaml too.

Yup I missed that one, thanks @sjakobi!

@Gabriella439
Copy link
Collaborator

@EggBaconAndSpam: Looks like the tests need to be updated for haskell-lsp-server-0.19, too

@EggBaconAndSpam
Copy link
Collaborator Author

Damn 😄 I'll fix it on Saturday!

haskell-lsp 0.19 requires at least lsp-test 0.9.
@EggBaconAndSpam
Copy link
Collaborator Author

Looks like we need a newer parser-combinators than the stack lts provides.

@Gabriella439
Copy link
Collaborator

@EggBaconAndSpam: Thank you! 🙂

@mergify mergify bot merged commit 172982a into master Jan 11, 2020
@mergify mergify bot deleted the frederik/update-haskell-lsp-to-0.19 branch January 11, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants