Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vets::Model file/namespace reorg #20919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenjcumming
Copy link
Contributor

Summary

  • No functional changes
  • Move model related classes under the vets/model directory

Vets::Type -> Vets::Model::Type

Related issue(s)

  • n/a

Testing done

  • local test suite run

Acceptance criteria

  • tests pass

Copy link

1 Error
🚫 This PR changes 677 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • lib/vets/attributes.rb (+0/-54)

  • lib/vets/attributes/value.rb (+0/-31)

  • lib/vets/model.rb (+2/-2)

  • lib/vets/model/attributes.rb (+56/-0)

  • lib/vets/model/attributes/value.rb (+33/-0)

  • lib/vets/model/type/array.rb (+40/-0)

  • lib/vets/model/type/base.rb (+18/-0)

  • lib/vets/model/type/date_time_string.rb (+18/-0)

  • lib/vets/model/type/hash.rb (+20/-0)

  • lib/vets/model/type/http_date.rb (+18/-0)

  • lib/vets/model/type/iso8601_time.rb (+18/-0)

  • lib/vets/model/type/object.rb (+19/-0)

  • lib/vets/model/type/primitive.rb (+31/-0)

  • lib/vets/model/type/titlecase_string.rb (+16/-0)

  • lib/vets/model/type/utc_time.rb (+18/-0)

  • lib/vets/model/types.rb (+9/-0)

  • lib/vets/type/array.rb (+0/-30)

  • lib/vets/type/base.rb (+0/-16)

  • lib/vets/type/date_time_string.rb (+0/-16)

  • lib/vets/type/hash.rb (+0/-18)

  • lib/vets/type/http_date.rb (+0/-16)

  • lib/vets/type/iso8601_time.rb (+0/-16)

  • lib/vets/type/object.rb (+0/-17)

  • lib/vets/type/primitive.rb (+0/-29)

  • lib/vets/type/titlecase_string.rb (+0/-14)

  • lib/vets/type/utc_time.rb (+0/-16)

  • lib/vets/types.rb (+0/-10)

  • spec/lib/vets/{ => model}/attributes/value_spec.rb (+11/-11)

  • spec/lib/vets/{ => model}/attributes_spec.rb (+5/-5)

  • spec/lib/vets/{ => model}/type/array_spec.rb (+4/-4)

  • spec/lib/vets/{ => model}/type/base_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/date_time_string_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/hash_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/http_date_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/iso8601_time_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/object_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/primitive_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/titlecase_string_spec.rb (+2/-2)

  • spec/lib/vets/{ => model}/type/utc_time_spec.rb (+2/-2)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants