Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Burials] Location of Death update #20909

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Burials] Location of Death update #20909

wants to merge 4 commits into from

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Feb 21, 2025

Summary

  • Updates vets-json-schema and adds handling for new Location of Death format. Previous schema is still supported.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • With burial_location_of_death_update disabled, submit the Burials form. Confirm it submits successfully.
  • With burial_location_of_death_update enabled, submit the Burials form. Confirm it submits successfully.

What areas of the site does it impact?

Burials

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@TaiWilkin TaiWilkin marked this pull request as ready for review February 21, 2025 20:57
@TaiWilkin TaiWilkin requested review from a team as code owners February 21, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530) require-backend-approval test-failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants