Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 45134 remove reg number job title #20876

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Feb 20, 2025

Summary

  • Removes registration id and job title from blue printer, schema, and tests.
  • Updates docs.
  • Removes unneeded args in controller & Sidekiq job.

Related issue(s)

Testing done

  • post {{uri}}/services/claims/v2/veterans/power-of-attorney-requests

request_body:

{
    "data": {
        "attributes": {
            "veteran": {
                "serviceNumber": "123678453",
                "serviceBranch": "ARMY",
                "address": {
                    "addressLine1": "2719 Hyperion Ave",
                    "addressLine2": "Apt 2",
                    "city": "Los Angeles",
                    "countryCode": "US",
                    "stateCode": "CA",
                    "zipCode": "92264",
                    "zipCodeSuffix": "0200"
                },
                "phone": {
                    "areaCode": "555",
                    "phoneNumber": "5551234"
                },
                "email": "[email protected]",
                "insuranceNumber": "1234567890"
            },
            "representative": {
                "poaCode": "067"
            },
            "recordConsent": true,
            "consentAddressChange": true,
            "consentLimits": [
                "DRUG_ABUSE",
                "SICKLE_CELL",
                "HIV",
                "ALCOHOLISM"
            ]
        }
    }
}

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added the claimsApi modules/claims_api label Feb 20, 2025
@stiehlrod stiehlrod self-assigned this Feb 20, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to API-45134-remove-reg-number-job-title/main/main February 20, 2025 16:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-45134-remove-reg-number-job-title/main/main February 20, 2025 17:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-45134-remove-reg-number-job-title/main/main February 20, 2025 17:40 Inactive
@stiehlrod stiehlrod marked this pull request as ready for review February 20, 2025 18:15
@stiehlrod stiehlrod requested a review from a team as a code owner February 20, 2025 18:15
@va-vfs-bot va-vfs-bot temporarily deployed to API-45134-remove-reg-number-job-title/main/main February 20, 2025 18:16 Inactive
@stiehlrod stiehlrod requested a review from a team February 24, 2025 14:53
@va-vfs-bot va-vfs-bot temporarily deployed to API-45134-remove-reg-number-job-title/main/main February 24, 2025 14:55 Inactive
@stiehlrod stiehlrod requested a review from a team February 24, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants