-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
101550: Update DR service to LH to use Common::Exceptions for API request errors #20812
Open
dfong-adh
wants to merge
6
commits into
master
Choose a base branch
from
101550-dr-use-upstream-error-class-for-lh-exceptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
101550: Update DR service to LH to use Common::Exceptions for API request errors #20812
dfong-adh
wants to merge
6
commits into
master
from
101550-dr-use-upstream-error-class-for-lh-exceptions
+213
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI request errors
kayline
reviewed
Feb 18, 2025
kayline
previously approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, approved!
stevenjcumming
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the Flipper enables in the spec to look like this
allow(Flipper).to receive(:enabled?).with(:feature_flag).and_return(false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yes. The behavior is behind the flipper flag
decision_review_service_common_exceptions_enabled
Our service class
DecisionReviews::V1::Service
primarily returnsDecisionReview::ServiceError
exceptions when errors occur while making API requests to other services. This PR updates the service to use the common exception classes inCommon::Exceptions
for status codes instead.Related issue(s)
department-of-veterans-affairs/va.gov-team#101550
Testing done
What areas of the site does it impact?
This impacts the Decision Review service and the format of data being logged to the PersonalInformationLog table.
Acceptance criteria