Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101550: Update DR service to LH to use Common::Exceptions for API request errors #20812

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dfong-adh
Copy link
Contributor

@dfong-adh dfong-adh commented Feb 15, 2025

Summary

  • This work is behind a feature toggle (flipper): YES/No
    Yes. The behavior is behind the flipper flag decision_review_service_common_exceptions_enabled

Our service class DecisionReviews::V1::Service primarily returns DecisionReview::ServiceError exceptions when errors occur while making API requests to other services. This PR updates the service to use the common exception classes in Common::Exceptions for status codes instead.

Related issue(s)

department-of-veterans-affairs/va.gov-team#101550

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

This impacts the Decision Review service and the format of data being logged to the PersonalInformationLog table.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@dfong-adh dfong-adh changed the title 101550: Update DR proxy service to LH to use Common::Exceptions for API request errors 101550: Update DR service to LH to use Common::Exceptions for API request errors Feb 15, 2025
kayline
kayline previously approved these changes Feb 18, 2025
Copy link
Contributor

@kayline kayline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, approved!

@dfong-adh dfong-adh marked this pull request as ready for review February 19, 2025 16:04
@dfong-adh dfong-adh requested review from a team as code owners February 19, 2025 16:04
Copy link
Contributor

@stevenjcumming stevenjcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Flipper enables in the spec to look like this

allow(Flipper).to receive(:enabled?).with(:feature_flag).and_return(false)

@stevenjcumming stevenjcumming requested a review from a team February 20, 2025 15:35
@va-vfs-bot va-vfs-bot temporarily deployed to 101550-dr-use-upstream-error-class-for-lh-exceptions/main/main February 20, 2025 20:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants