Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dossier): backfill dossier depose traitement revision #11393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tchak
Copy link
Member

@tchak tchak commented Mar 4, 2025

No description provided.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69.52%. Comparing base (b4179fb) to head (0485ae1).

Files with missing lines Patch % Lines
.../t20250304_backfill_traitement_revision_id_task.rb 0.00% 21 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b4179fb) and HEAD (0485ae1). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (b4179fb) HEAD (0485ae1)
16 5
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11393       +/-   ##
===========================================
- Coverage   84.68%   69.52%   -15.16%     
===========================================
  Files        1222     1223        +1     
  Lines       27033    28489     +1456     
  Branches     5151     4777      -374     
===========================================
- Hits        22892    19808     -3084     
- Misses       4141     8681     +4540     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the backfill-revision-deposer-at branch from bf983aa to 0485ae1 Compare March 4, 2025 10:30
def collection
Traitement.joins(dossier: :procedure)
.where(state: Dossier.states.fetch(:en_construction), revision_id: nil)
.where('traitements.processed_at = dossiers.depose_at')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on est sûr que ça peut être égal au millième de seconde près ? je veux dire que c'est la même date qui est copiée ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que le scope de la collection va changer à chaque en permanence, donc faudra jouer la task plusieurs fois mais ça me gène pas vu que c'est exceptionnel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants