-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech] Suppression de code obsolète (path) #11337
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11337 +/- ##
===========================================
- Coverage 84.68% 55.39% -29.30%
===========================================
Files 1222 1221 -1
Lines 27033 29666 +2633
Branches 5151 4417 -734
===========================================
- Hits 22892 16432 -6460
- Misses 4141 13234 +9093 ☔ View full report in Codecov by Sentry. |
29ccfe9
to
2accc57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top, merci pour le cleanup.
il faudra bien faire attention a préciser dans la release note que la tache migrate_existing_procedure_paths_task
doit être joué avant de mettre en place cette version.
end | ||
|
||
def path | ||
canonical_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
est ce qu'on pourrait inliner canonical_path
ici pour ne pas avoir de doublon ?
Le lien d'une démarche n'étant plus porté l'attribut
path
mais par lehas_many :procedure_path
, cette PR ignore lepath
en vue de la suppression de l'attribut de la tableProcedures
dans une prochaine migration.