Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech] Suppression de code obsolète (path) #11337

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Tech] Suppression de code obsolète (path) #11337

wants to merge 9 commits into from

Conversation

mmagn
Copy link
Contributor

@mmagn mmagn commented Feb 18, 2025

Le lien d'une démarche n'étant plus porté l'attribut path mais par le has_many :procedure_path, cette PR ignore le path en vue de la suppression de l'attribut de la table Procedures dans une prochaine migration.

@mmagn mmagn changed the title Clean path [Tech] Suppression de code obsolète (path) Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.39%. Comparing base (b4179fb) to head (4345344).

❗ There is a different number of reports uploaded between BASE (b4179fb) and HEAD (4345344). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (b4179fb) HEAD (4345344)
16 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11337       +/-   ##
===========================================
- Coverage   84.68%   55.39%   -29.30%     
===========================================
  Files        1222     1221        -1     
  Lines       27033    29666     +2633     
  Branches     5151     4417      -734     
===========================================
- Hits        22892    16432     -6460     
- Misses       4141    13234     +9093     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmagn mmagn force-pushed the clean_path branch 2 times, most recently from 29ccfe9 to 2accc57 Compare February 18, 2025 17:21
@mmagn mmagn marked this pull request as ready for review February 18, 2025 17:52
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top, merci pour le cleanup.

il faudra bien faire attention a préciser dans la release note que la tache migrate_existing_procedure_paths_task doit être joué avant de mettre en place cette version.

end

def path
canonical_path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est ce qu'on pourrait inliner canonical_path ici pour ne pas avoir de doublon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants