-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main]
Implement Mutli-Lingual and Missing Speaker/NumWords
#314
[main]
Implement Mutli-Lingual and Missing Speaker/NumWords
#314
Conversation
WalkthroughThe recent updates include the addition of language detection capabilities across various models in the Deepgram REST and WebSocket APIs. New properties were introduced to store language information for words and transcription alternatives, along with adjustments to some access modifiers to improve data accessibility. Changes
Sequence Diagram(s)Since the changes involve adding new properties and modifying existing ones without altering core control flow, no sequence diagrams are necessary for these updates. The additions are primarily enhancements aimed at improving the data model for existing processes Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- Deepgram/Models/Listen/v1/REST/Alternative.cs (1 hunks)
- Deepgram/Models/Listen/v1/REST/Paragraph.cs (2 hunks)
- Deepgram/Models/Listen/v1/REST/Word.cs (1 hunks)
- Deepgram/Models/Listen/v1/WebSocket/Alternative.cs (1 hunks)
- Deepgram/Models/Listen/v1/WebSocket/Word.cs (1 hunks)
Additional comments not posted (6)
Deepgram/Models/Listen/v1/WebSocket/Alternative.cs (1)
29-34
: New propertyLanguages
added correctly.The
Languages
property is correctly annotated for JSON serialization and follows the existing pattern of the class.Deepgram/Models/Listen/v1/REST/Paragraph.cs (2)
21-21
: Access modifier forNumWords
changed to public.The
NumWords
property now has a public access modifier, increasing its accessibility.
30-35
: New propertySpeaker
added correctly.The
Speaker
property is correctly annotated for JSON serialization and follows the existing pattern of the class.Deepgram/Models/Listen/v1/WebSocket/Word.cs (1)
44-49
: New propertyLanguage
added correctly.The
Language
property is correctly annotated for JSON serialization and follows the existing pattern of the class.Deepgram/Models/Listen/v1/REST/Word.cs (1)
24-29
: New propertyLanguage
added correctly.The
Language
property is correctly annotated for JSON serialization and follows the existing pattern of the class.Deepgram/Models/Listen/v1/REST/Alternative.cs (1)
24-30
: LGTM! The newLanguages
property is well-integrated.The addition of the
Languages
property follows the existing pattern and is correctly annotated for JSON serialization.
This implements multi-lingual support for
main
branch. This is implemented in the temp branch here:https://github.com/dvonthenen/deepgram-python-sdk/tree/temp-v40-rel
Did not test. Implemented per the spec since this was pretty straight forward.
Summary by CodeRabbit
New Features
Enhancements
NumWords
property in the Paragraph model publicly accessible.Speaker
property to the Paragraph model for identifying speakers.